{AKS} Implicitly enable istio when ingress gateway is enabled for Azure Service Mesh #7240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deveshdama
requested review from
andyliuliming and
FumingZhang
as code owners
|
Hi @deveshdama, |
️✔️Azure CLI Extensions Breaking Change Test
|
|
Hi @deveshdama, |
|
AKS |
microsoft-github-policy-service
bot
requested review from
zhoxing-ms,
yanzhudd and
yonzhan
SanyaKochhar
approved these changes
Feb 1, 2024
FumingZhang
reviewed
Feb 2, 2024
FumingZhang
reviewed
Feb 4, 2024
| @@ -13,6 +13,7 @@ Pending | |||
| +++++++ | |||
| * Deprecate the alias "-r" of parameter --source-resource-id in `az aks trustedaccess rolebinding create` | |||
| * Refactor azure service mesh related code to meet cli style requirements. | |||
| * Implicitly enable istio when ingress or egress gateway is enabled for Azure Service Mesh. | |||
There was a problem hiding this comment.
Could you rebase/merge latest main? History note have changed here.
* Add support for reconcile commands and update version to 1.0.3 * WIP - Enable hubprofile PUT for Fleet. * Logic Checks * Revert "Logic Checks" This reverts commit 63f35a7. * Revert "WIP - Enable hubprofile PUT for Fleet." This reverts commit 8fdd475. * Updated history. * Added it_match & lint fix. * Updated test. * test update * Update test results * lint fix, help text added. * typo fix * Removed testing code. Co-authored-by: Jim Minter <[email protected]> --------- Co-authored-by: Jim Minter <[email protected]>
Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/azclitools/internal/_build/results?buildId=127141&view=results Last commit: a150d29
Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/azclitools/internal/_build/results?buildId=127156&view=results Last commit: 70b8109
* add message id
…gned and --mi-user-assigned, support 'az containerapp env identity assign/remove/show' (#7226)
Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/azclitools/internal/_build/results?buildId=127465&view=results Last commit: 46d22e7
deveshdama
requested review from
kairu-ms,
jsntcy,
jiasli,
evelyn-ys and
necusjz
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az aks mesh enable-ingress-gatewayGeneral Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.