Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NGINX.NGINXPLUS 1.0.0 #7247

Merged
merged 15 commits into from
Mar 7, 2024
Merged

Conversation

george-ngugi
Copy link
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
    ===============
    | Style Check |
    ===============

Extensions: nginx

Running pylint on extensions...
Pylint: PASSED

Running flake8 on extensions...
Flake8: PASSED

  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
    Ran 9 tests in 0.068s

OK (skipped=2)

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Feb 2, 2024

❌Azure CLI Extensions Breaking Change Test
❌nginx
rule cmd_name rule_message suggest_message
1007 - ParaRemove nginx deployment certificate create cmd nginx deployment certificate create removed parameter provisioning_state please add back parameter provisioning_state for cmd nginx deployment certificate create
1007 - ParaRemove nginx deployment certificate create cmd nginx deployment certificate create removed parameter tags please add back parameter tags for cmd nginx deployment certificate create
1007 - ParaRemove nginx deployment certificate update cmd nginx deployment certificate update removed parameter provisioning_state please add back parameter provisioning_state for cmd nginx deployment certificate update
1007 - ParaRemove nginx deployment certificate update cmd nginx deployment certificate update removed parameter tags please add back parameter tags for cmd nginx deployment certificate update
1007 - ParaRemove nginx deployment configuration create cmd nginx deployment configuration create removed parameter provisioning_state please add back parameter provisioning_state for cmd nginx deployment configuration create
1007 - ParaRemove nginx deployment configuration create cmd nginx deployment configuration create removed parameter tags please add back parameter tags for cmd nginx deployment configuration create
1002 - CmdRemove nginx deployment configuration update cmd nginx deployment configuration update removed please confirm cmd nginx deployment configuration update removed
1007 - ParaRemove nginx deployment create cmd nginx deployment create removed parameter managed_resource_group please add back parameter managed_resource_group for cmd nginx deployment create
1007 - ParaRemove nginx deployment create cmd nginx deployment create removed parameter provisioning_state please add back parameter provisioning_state for cmd nginx deployment create
1007 - ParaRemove nginx deployment update cmd nginx deployment update removed parameter managed_resource_group please add back parameter managed_resource_group for cmd nginx deployment update
1007 - ParaRemove nginx deployment update cmd nginx deployment update removed parameter provisioning_state please add back parameter provisioning_state for cmd nginx deployment update
⚠️ 1009 - ParaPropRemove nginx deployment certificate create cmd nginx deployment certificate create update parameter certificate_name: removed property id_part=child_name_1
⚠️ 1009 - ParaPropRemove nginx deployment certificate create cmd nginx deployment certificate create update parameter deployment_name: removed property id_part=name
⚠️ 1006 - ParaAdd nginx deployment certificate list cmd nginx deployment certificate list added parameter pagination_limit
⚠️ 1006 - ParaAdd nginx deployment certificate list cmd nginx deployment certificate list added parameter pagination_token
⚠️ 1001 - CmdAdd nginx deployment configuration analyze cmd nginx deployment configuration analyze added
⚠️ 1009 - ParaPropRemove nginx deployment configuration create cmd nginx deployment configuration create update parameter configuration_name: removed property id_part=child_name_1
⚠️ 1009 - ParaPropRemove nginx deployment configuration create cmd nginx deployment configuration create update parameter deployment_name: removed property id_part=name
⚠️ 1006 - ParaAdd nginx deployment configuration list cmd nginx deployment configuration list added parameter pagination_limit
⚠️ 1006 - ParaAdd nginx deployment configuration list cmd nginx deployment configuration list added parameter pagination_token
⚠️ 1006 - ParaAdd nginx deployment create cmd nginx deployment create added parameter scaling_properties
⚠️ 1006 - ParaAdd nginx deployment create cmd nginx deployment create added parameter user_profile
⚠️ 1009 - ParaPropRemove nginx deployment create cmd nginx deployment create update parameter deployment_name: removed property id_part=name
⚠️ 1006 - ParaAdd nginx deployment list cmd nginx deployment list added parameter pagination_limit
⚠️ 1006 - ParaAdd nginx deployment list cmd nginx deployment list added parameter pagination_token
⚠️ 1006 - ParaAdd nginx deployment update cmd nginx deployment update added parameter scaling_properties
⚠️ 1006 - ParaAdd nginx deployment update cmd nginx deployment update added parameter user_profile

Copy link

Hi @george-ngugi,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

@yonzhan
Copy link
Collaborator

yonzhan commented Feb 2, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

@microsoft-github-policy-service microsoft-github-policy-service bot added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Feb 2, 2024
@george-ngugi george-ngugi changed the title NGINX.NGINXPLUS v2 NGINX.NGINXPLUS 1.0.0 Feb 8, 2024
@george-ngugi
Copy link
Contributor Author

Hi @jsntcy
Could you please take a look

@agazeley
Copy link

Might be worth having a constant for the api-version to avoid magic strings or potential errors in the future

@jsntcy jsntcy requested a review from AllyW March 1, 2024 09:54
@jsntcy
Copy link
Member

jsntcy commented Mar 1, 2024

@necusjz, @AllyW , please check if those breaking changes are expected as breaking changes should only be allowed in breaking change windows.

@necusjz
Copy link
Member

necusjz commented Mar 6, 2024

@george-ngugi could you please update the pr in aaz repo Azure/aaz#403, to manually trigger the pipeline? thanks.

@george-ngugi
Copy link
Contributor Author

@george-ngugi could you please update the pr in aaz repo Azure/aaz#403, to manually trigger the pipeline? thanks.

@necusjz done

@necusjz necusjz merged commit 319e048 into Azure:main Mar 7, 2024
15 checks passed
@azclibot
Copy link
Collaborator

azclibot commented Mar 7, 2024

[Release] Update index.json for extension [ nginx ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=137402&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customer-reported Issues that are reported by GitHub users external to the Azure organization.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants