-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix tenant ID retrieval #7250
fix tenant ID retrieval #7250
Conversation
️✔️Azure CLI Extensions Breaking Change Test
|
Hi @TheOnlyWei, |
Thank you for your contribution! We will review the pull request and get back to you soon. |
@TheOnlyWei, please fix CI error first. |
Hi @jsntcy, can you merge this PR first? It reverts the version with the bug from being downloaded by customers. Regarding the azdev style failure, the connectedk8s team plans on a separate task to fix azdev style issue in the future. These azdev style errors has always been there before my changes. I already verified in the azdev style pipeline that my changes did not cause any new issues, so please ignore the azdev style pipeline. |
I saw this CI error existed for several months, please provide an ETA to fix it; otherwise "in the future" means never fixing. |
@jsntcy I would fix it myself, but I don't work on the team that owns connectedk8s. I am just contributing. I have pointed out this issue to the owners before. I can ping them here as well. @NarayanThiru Do you have an ETA when the azdev style issues will be fixed? |
Although the style issues don't block PR merge so far, we will change it to merge PR block in the future. |
@jsntcy Regardless, I am just a contributor and is not part of the owning team for connectedk8s. This change should go in before someone else makes a PR and merges into connectedk8s and reintroduces the reverted change from: |
[Release] Update index.json for extension [ connectedk8s ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=127632&view=results |
Related command
az connectedk8s
Try to merge the below PR first before this PR:
#7251
It seems the connectedk8s live test doesn't work properly, probably because the command is being run as a subprocess, since it passed when it should have failed:
azure-cli-extensions/src/connectedk8s/azext_connectedk8s/tests/latest/test_connectedk8s_scenario.py
Line 584 in 06ad14f
So, I did not catch the issue. Ideally, we have a fully automated test pipeline for connectedk8s, but currently we have to run a bunch of manual tests. Other teams seem to have better tests for connectedk8s than connectedk8s has for itself.
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally? (pip install wheel==0.30.0
required)About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.json
automatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json
.