Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix tenant ID retrieval #7250

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Conversation

TheOnlyWei
Copy link
Contributor

@TheOnlyWei TheOnlyWei commented Feb 3, 2024

Related command

az connectedk8s

Try to merge the below PR first before this PR:
#7251

It seems the connectedk8s live test doesn't work properly, probably because the command is being run as a subprocess, since it passed when it should have failed:

script = ['az','connectedk8s', 'proxy', '-n', name, '-g', resource_group, '-f' , kubeconfig2, '&']

So, I did not catch the issue. Ideally, we have a fully automated test pipeline for connectedk8s, but currently we have to run a bunch of manual tests. Other teams seem to have better tests for connectedk8s than connectedk8s has for itself.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Feb 3, 2024

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

Copy link

Hi @TheOnlyWei,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

@yonzhan
Copy link
Collaborator

yonzhan commented Feb 3, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

@jsntcy
Copy link
Member

jsntcy commented Feb 4, 2024

@TheOnlyWei, please fix CI error first.

@TheOnlyWei
Copy link
Contributor Author

TheOnlyWei commented Feb 4, 2024

@TheOnlyWei, please fix CI error first.

Hi @jsntcy, can you merge this PR first? It reverts the version with the bug from being downloaded by customers.
#7251

Regarding the azdev style failure, the connectedk8s team plans on a separate task to fix azdev style issue in the future. These azdev style errors has always been there before my changes. I already verified in the azdev style pipeline that my changes did not cause any new issues, so please ignore the azdev style pipeline.

@TheOnlyWei TheOnlyWei mentioned this pull request Feb 4, 2024
3 tasks
@jsntcy
Copy link
Member

jsntcy commented Feb 4, 2024

@TheOnlyWei, please fix CI error first.

Hi @jsntcy, can you merge this PR first? It reverts the version with the bug from being downloaded by customers. #7251

Regarding the azdev style failure, the connectedk8s team plans on a separate task to fix azdev style issue in the future. These azdev style errors has always been there before my changes. I already verified in the azdev style pipeline that my changes did not cause any new issues, so please ignore the azdev style pipeline.

I saw this CI error existed for several months, please provide an ETA to fix it; otherwise "in the future" means never fixing.

#7103
#7111
#7139

@TheOnlyWei
Copy link
Contributor Author

@jsntcy I would fix it myself, but I don't work on the team that owns connectedk8s. I am just contributing. I have pointed out this issue to the owners before. I can ping them here as well.

@NarayanThiru Do you have an ETA when the azdev style issues will be fixed?

@jsntcy
Copy link
Member

jsntcy commented Feb 4, 2024

@jsntcy Yu Chen FTE I would fix it myself, but I don't work on the team that owns connectedk8s. I am just contributing. I have pointed out this issue to the owners before. I can ping them here as well.

@NarayanThiru Narayan Thiru FTE Do you have an ETA when the azdev style issues will be fixed?

Although the style issues don't block PR merge so far, we will change it to merge PR block in the future.

@TheOnlyWei
Copy link
Contributor Author

TheOnlyWei commented Feb 4, 2024

@jsntcy Regardless, I am just a contributor and is not part of the owning team for connectedk8s. This change should go in before someone else makes a PR and merges into connectedk8s and reintroduces the reverted change from:
#7251
For azdev style issue, you should work with @NarayanThiru to get that resolved. My change did not introduce new azdev style issues.

@jsntcy jsntcy merged commit e631536 into Azure:main Feb 5, 2024
19 of 20 checks passed
@azclibot
Copy link
Collaborator

azclibot commented Feb 5, 2024

[Release] Update index.json for extension [ connectedk8s ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=127632&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants