Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ContainerApp] Fix: az containerapp create --yaml always shows warning. #7279

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

abij
Copy link

@abij abij commented Feb 8, 2024

Small fix for the warning: Additional flags were passed along with --yaml. These flags will be ignored, and the configuration defined in the yaml will be used instead.

The documentation states that the default value for revisions_mode (ActiveRevisionsMode) is "Single": containerapps-2023-08-01-preview

When this is initialised to None, like most values, the warning does not appear.


General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

Copy link

azure-client-tools-bot-prd bot commented Feb 8, 2024

⚠️Azure CLI Extensions Breaking Change Test
⚠️containerapp
rule cmd_name rule_message suggest_message
⚠️ 1009 - ParaPropRemove containerapp create cmd containerapp create update parameter revisions_mode: removed property default=single

Copy link

Hi @abij,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Feb 8, 2024

ContainerApp

Copy link
Contributor

Thank you for your contribution abij! We will review the pull request and get back to you soon.

@abij
Copy link
Author

abij commented Feb 8, 2024

related issue: #7276

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Assign Auto assign by bot ContainerApp customer-reported Issues that are reported by GitHub users external to the Azure organization.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants