[AKS] Add a new command to check outbound network from nodes `az aks check-network outbound` #7280

alyssa1303 · 2024-02-09T20:49:22Z

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az aks check-network outbound

General Guidelines

Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
My extension version conforms to the Extension version schema

For new extensions:

My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

azure-client-tools-bot-prd · 2024-02-09T20:49:25Z

⚠️Azure CLI Extensions Breaking Change Test

⚠️aks-preview

rule cmd_name rule_message suggest_message

⚠️ 1011 - SubgroupAdd aks check-network sub group aks check-network added

azure-client-tools-bot-prd · 2024-02-09T20:49:28Z

Hi @alyssa1303,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

yonzhan · 2024-02-09T20:49:33Z

AKS

alyssa1303 · 2024-02-28T20:44:13Z

Please add some unit test cases (see examples in test_helpers.py) and at least one live test case (see examples in test_aks_commands.py) for the newly added command.

I've finished adding unit test and live test. All CI passes except for the Cred run which I believe need help from CI team

zhoxing-ms · 2024-02-29T04:13:33Z

@yanzhudd Could you please help review this PR?

src/aks-preview/HISTORY.rst

src/aks-preview/azext_aks_preview/tests/latest/test_aks_commands.py

src/aks-preview/azext_aks_preview/custom.py

FumingZhang · 2024-02-29T07:48:27Z

Please also resolve the merge conflicts.

gitguardian · 2024-02-29T21:28:43Z

⚠️ GitGuardian has uncovered 61 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request

GitGuardian id	Secret	Commit	Filename
-	Microsoft Azure Storage Account Key	`650a869`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_get_customdomainverificationid_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`650a869`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_get_customdomainverificationid_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`650a869`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_storage.yaml	View secret
-	Microsoft Azure Storage Account Key	`650a869`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_identity_system.yaml	View secret
-	Microsoft Azure Storage Account Key	`650a869`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_identity_system.yaml	View secret
-	Microsoft Azure Storage Account Key	`650a869`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`650a869`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`650a869`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`650a869`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_mtls.yaml	View secret
-	Microsoft Azure Storage Account Key	`650a869`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_create_with_vnet_yaml.yaml	View secret
-	Microsoft Azure Storage Account Key	`650a869`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_create_with_vnet_yaml.yaml	View secret
-	Microsoft Azure Storage Account Key	`650a869`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_certificate_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`650a869`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_update_custom_domains.yaml	View secret
-	Microsoft Azure Storage Account Key	`650a869`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_update_custom_domains.yaml	View secret
-	Microsoft Azure Storage Account Key	`650a869`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_custom_domains_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`650a869`	src/containerapp/azext_containerapp/tests/latest/recordings/test_container_app_mount_secret_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`650a869`	src/containerapp/azext_containerapp/tests/latest/recordings/test_container_app_mount_secret_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`650a869`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_custom_domains_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`650a869`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_custom_domains_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`650a869`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_usages.yaml	View secret
-	Microsoft Azure Storage Account Key	`650a869`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_custom_domains.yaml	View secret
-	Microsoft Azure Storage Account Key	`650a869`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_update_custom_domains.yaml	View secret
-	Microsoft Azure Storage Account Key	`650a869`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_custom_domains.yaml	View secret
-	Microsoft Azure Storage Account Key	`650a869`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_custom_domains.yaml	View secret
-	Microsoft Azure Storage Account Key	`650a869`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_custom_domains.yaml	View secret
-	Microsoft Azure Storage Account Key	`650a869`	src/containerapp/azext_containerapp/tests/latest/recordings/test_container_app_mount_secret_update_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`650a869`	src/containerapp/azext_containerapp/tests/latest/recordings/test_container_app_mount_secret_update_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`650a869`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_la_dynamic_json.yaml	View secret
-	Microsoft Azure Storage Account Key	`650a869`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_create_with_vnet_yaml.yaml	View secret
-	Microsoft Azure Storage Account Key	`650a869`	src/containerapp/azext_containerapp/tests/latest/recordings/test_container_app_mount_azurefile_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`650a869`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_certificate_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`650a869`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_certificate_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`650a869`	src/containerapp/azext_containerapp/tests/latest/recordings/test_container_app_mount_secret_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`650a869`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_logs_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`650a869`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_logs_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`650a869`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_logs_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`650a869`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_dapr_components.yaml	View secret
-	Microsoft Azure Storage Account Key	`650a869`	src/containerapp/azext_containerapp/tests/latest/recordings/test_container_app_mount_secret_update_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`650a869`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_dapr_components.yaml	View secret
-	Microsoft Azure Storage Account Key	`650a869`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_dapr_components.yaml	View secret
-	Microsoft Azure Storage Account Key	`650a869`	src/containerapp/azext_containerapp/tests/latest/recordings/test_container_app_mount_nfsazurefile_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`650a869`	src/containerapp/azext_containerapp/tests/latest/recordings/test_container_app_mount_nfsazurefile_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`650a869`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_storage.yaml	View secret
-	Microsoft Azure Storage Account Key	`650a869`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_storage.yaml	View secret
-	Microsoft Azure Storage Account Key	`650a869`	src/containerapp/azext_containerapp/tests/latest/recordings/test_container_app_mount_azurefile_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`650a869`	src/containerapp/azext_containerapp/tests/latest/recordings/test_container_app_mount_azurefile_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`650a869`	src/containerapp/azext_containerapp/tests/latest/recordings/test_container_app_mount_nfsazurefile_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`650a869`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_get_customdomainverificationid_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`650a869`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_internal_only_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`650a869`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_usages.yaml	View secret
-	Microsoft Azure Storage Account Key	`650a869`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_usages.yaml	View secret
-	Microsoft Azure Storage Account Key	`650a869`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_identity_system.yaml	View secret
-	Microsoft Azure Storage Account Key	`650a869`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_la_dynamic_json.yaml	View secret
-	Microsoft Azure Storage Account Key	`650a869`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_la_dynamic_json.yaml	View secret
-	Microsoft Azure Storage Account Key	`650a869`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_la_dynamic_json.yaml	View secret
-	Microsoft Azure Storage Account Key	`650a869`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_la_dynamic_json.yaml	View secret
-	Microsoft Azure Storage Account Key	`650a869`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_logs_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`650a869`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_mtls.yaml	View secret
-	Microsoft Azure Storage Account Key	`650a869`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_mtls.yaml	View secret
-	Microsoft Azure Storage Account Key	`650a869`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_internal_only_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`650a869`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_internal_only_e2e.yaml	View secret

🛠 Guidelines to remediate hardcoded secrets

Understand the implications of revoking this secret by investigating where it is used in your code.
Replace and store your secrets safely. Learn here the best practices.
Revoke and rotate these secrets.
If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

following these best practices for managing and storing secrets including API keys and other credentials
install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!}

alyssa1303 · 2024-03-01T00:20:26Z

⚠️ GitGuardian has uncovered 61 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
🛠 Guidelines to remediate hardcoded secrets
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.Our GitHub checks need improvements? Share your feedbacks!

Can someone help me look into this problem? Seem like a serious one but I'm pretty sure it's not from my change but something from the main branch after I got the latest change @zhoxing-ms @yanzhudd @FumingZhang

FumingZhang · 2024-03-01T02:06:34Z

/azp run

azure-pipelines · 2024-03-01T02:06:45Z

Azure Pipelines successfully started running 2 pipeline(s).

FumingZhang · 2024-03-01T03:30:58Z

/azp run

azure-pipelines · 2024-03-01T03:31:10Z

Azure Pipelines successfully started running 2 pipeline(s).

github-actions · 2024-03-15T09:24:50Z

⚠️ Suggestions

Module: aks-preview

Update version to 2.0.0b8 in setup.py
Set azext.isPreview to true in azext_aks-preview/azext_metadata.json if not exists

Notes

Stable/preview tag is inherited from last release. If needed, please add stable/preview label to modify it.
Major/minor/patch/pre increment of version number is calculated by pull request code changes automatically. If needed, please add major/minor/patch/pre label to adjust it.
For more info about extension versioning, please refer to Extension version schema

FumingZhang · 2024-03-28T02:45:00Z

Default API version has been updated to 2024-02-02-preview, the recording file of test_aks_check_network is outdated so the CI failed. Requeued live test.

FumingZhang

LGTM

src/aks-preview/HISTORY.rst

src/aks-preview/azext_aks_preview/_params.py

src/aks-preview/azext_aks_preview/_validators.py

FumingZhang · 2024-04-02T02:47:44Z

Requeued another live test including recent changes. Test passed!

alyssa1303 added 4 commits February 6, 2024 19:54

implement az aks check-network outbound

5e0f989

get rid of dependency on kubectl

44a3bd3

update handling of instance_id

5d28faa

add support for AvailabilitySet

1a128b6

alyssa1303 requested review from andyliuliming and FumingZhang as code owners February 9, 2024 20:49

azure-client-tools-bot-prd bot added this to the February 2024 (2024-03-05) milestone Feb 9, 2024

microsoft-github-policy-service bot requested review from zhoxing-ms, yanzhudd, yonzhan, jsntcy, kairu-ms and necusjz February 9, 2024 20:49

microsoft-github-policy-service bot assigned yanzhudd and zhoxing-ms Feb 9, 2024

microsoft-github-policy-service bot added Auto-Assign Auto assign by bot AKS labels Feb 9, 2024

microsoft-github-policy-service bot assigned necusjz Feb 9, 2024

microsoft-github-policy-service bot added the Network label Feb 9, 2024

alyssa1303 added 3 commits February 9, 2024 20:49

fix lint error

57267e3

resolve conflict

acabf5c

fix style issue

0d27b0e

yonzhan unassigned necusjz Feb 9, 2024

yonzhan removed the Network label Feb 9, 2024

alyssa1303 added 3 commits February 10, 2024 20:02

fix style issue

1428121

break function into smaller ones

df3a0d3

fix style issue

4a5b53d

FumingZhang reviewed Feb 29, 2024

View reviewed changes

resolve conflict

650a869

alyssa1303 added 2 commits February 29, 2024 23:06

update HISTORY and logging command

80e9d00

remove unused else

3d933ae

AllyW added the auto-cal-version label Mar 15, 2024

get latest change from main

4f8c055

update required image version and remove fqdn input

66e64fd

alyssa1303 force-pushed the alyssa/aks-check-network branch from ea5b513 to 66e64fd Compare March 29, 2024 23:13

update live test

d603cb1

FumingZhang approved these changes Mar 30, 2024

View reviewed changes

yanzhudd reviewed Apr 1, 2024

View reviewed changes

src/aks-preview/HISTORY.rst Outdated Show resolved Hide resolved

yanzhudd reviewed Apr 1, 2024

View reviewed changes

src/aks-preview/azext_aks_preview/_params.py Outdated Show resolved Hide resolved

yanzhudd reviewed Apr 1, 2024

View reviewed changes

src/aks-preview/azext_aks_preview/_validators.py Outdated Show resolved Hide resolved

alyssa1303 force-pushed the alyssa/aks-check-network branch from 2241b54 to 12bfed1 Compare April 1, 2024 23:10

update custom endpoints

783a480

alyssa1303 force-pushed the alyssa/aks-check-network branch from 12bfed1 to 783a480 Compare April 1, 2024 23:29

yanzhudd approved these changes Apr 2, 2024

View reviewed changes

yanzhudd merged commit 0c6adfd into Azure:main Apr 2, 2024
15 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[AKS] Add a new command to check outbound network from nodes `az aks check-network outbound` #7280

[AKS] Add a new command to check outbound network from nodes `az aks check-network outbound` #7280

alyssa1303 commented Feb 9, 2024 •

edited

Loading

azure-client-tools-bot-prd bot commented Feb 9, 2024 •

edited

Loading

azure-client-tools-bot-prd bot commented Feb 9, 2024

yonzhan commented Feb 9, 2024

alyssa1303 commented Feb 28, 2024

zhoxing-ms commented Feb 29, 2024

FumingZhang commented Feb 29, 2024

gitguardian bot commented Feb 29, 2024 •

edited

Loading

alyssa1303 commented Mar 1, 2024

⚠️ GitGuardian has uncovered 61 secrets following the scan of your pull request.

FumingZhang commented Mar 1, 2024

azure-pipelines bot commented Mar 1, 2024

FumingZhang commented Mar 1, 2024

azure-pipelines bot commented Mar 1, 2024

github-actions bot commented Mar 15, 2024 •

edited

Loading

FumingZhang commented Mar 28, 2024

FumingZhang left a comment

FumingZhang commented Apr 2, 2024

[AKS] Add a new command to check outbound network from nodes az aks check-network outbound #7280

[AKS] Add a new command to check outbound network from nodes az aks check-network outbound #7280

Conversation

alyssa1303 commented Feb 9, 2024 • edited Loading

Related command

General Guidelines

About Extension Publish

azure-client-tools-bot-prd bot commented Feb 9, 2024 • edited Loading

azure-client-tools-bot-prd bot commented Feb 9, 2024

yonzhan commented Feb 9, 2024

alyssa1303 commented Feb 28, 2024

zhoxing-ms commented Feb 29, 2024

FumingZhang commented Feb 29, 2024

gitguardian bot commented Feb 29, 2024 • edited Loading

⚠️ GitGuardian has uncovered 61 secrets following the scan of your pull request.

alyssa1303 commented Mar 1, 2024

⚠️ GitGuardian has uncovered 61 secrets following the scan of your pull request.

FumingZhang commented Mar 1, 2024

azure-pipelines bot commented Mar 1, 2024

FumingZhang commented Mar 1, 2024

azure-pipelines bot commented Mar 1, 2024

github-actions bot commented Mar 15, 2024 • edited Loading

⚠️ Suggestions

Module: aks-preview

Notes

FumingZhang commented Mar 28, 2024

FumingZhang left a comment

Choose a reason for hiding this comment

FumingZhang commented Apr 2, 2024

[AKS] Add a new command to check outbound network from nodes `az aks check-network outbound` #7280

[AKS] Add a new command to check outbound network from nodes `az aks check-network outbound` #7280

alyssa1303 commented Feb 9, 2024 •

edited

Loading

azure-client-tools-bot-prd bot commented Feb 9, 2024 •

edited

Loading

gitguardian bot commented Feb 29, 2024 •

edited

Loading

github-actions bot commented Mar 15, 2024 •

edited

Loading