Update connectedk8s helm binary download source & introduce new --skip-cluster-ssl-verification flag #7294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| connectedk8s connect | cmd connectedk8s connect added parameter skip_ssl_verification |
||
| connectedk8s delete | cmd connectedk8s delete added parameter skip_ssl_verification |
||
| connectedk8s disable-features | cmd connectedk8s disable-features added parameter skip_ssl_verification |
||
| connectedk8s enable-features | cmd connectedk8s enable-features added parameter skip_ssl_verification |
||
| connectedk8s troubleshoot | cmd connectedk8s troubleshoot added parameter skip_ssl_verification |
||
| connectedk8s update | cmd connectedk8s update added parameter skip_ssl_verification |
||
| connectedk8s upgrade | cmd connectedk8s upgrade added parameter skip_ssl_verification |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
microsoft-github-policy-service
bot
requested review from
zhoxing-ms,
jsntcy,
yonzhan and
yanzhudd
microsoft-github-policy-service
bot
added
Connected Kubernetes
Auto-Assign
kitnhl
approved these changes
Feb 20, 2024
sidiesen
force-pushed
the
sidiesen/helm_location
branch
2 times, most recently
from
b9b4c63
to
86239eb
Compare
kitnhl
approved these changes
Feb 20, 2024
|
Please fix CI issues. |
sidiesen
force-pushed
the
sidiesen/helm_location
branch
2 times, most recently
from
7b0e248
to
3dcd47a
Compare
sidiesen
force-pushed
the
sidiesen/helm_location
branch
4 times, most recently
from
3dcd47a
to
f4deaa5
Compare
sidiesen
force-pushed
the
sidiesen/helm_location
branch
3 times, most recently
from
911f53f
to
0ff2c3b
Compare
sidiesen
force-pushed
the
sidiesen/helm_location
branch
from
0ff2c3b
to
c0b51d2
Compare
|
AllyW
reviewed
Apr 17, 2024
sidiesen
force-pushed
the
sidiesen/helm_location
branch
from
1143827
to
be7a9d5
Compare
AllyW
approved these changes
Apr 18, 2024
zhoxing-ms
reviewed
Apr 19, 2024
|
|
||
| @live_only() |
There was a problem hiding this comment.
May I ask why do you need to mark this test as @live_only()?
There was a problem hiding this comment.
This test is exercising the exact same paths as a different test in this file that is already marked as @live_only(), just with the added parameter to skip ssl verification when connecting to the cluster.
I believe that test was marked as live only as the necessary creation of Azure resources in these tests was causing issues in non-live test settings.
zhoxing-ms
reviewed
Apr 19, 2024
| @@ -49,6 +49,7 @@ def load_arguments(self, _): | |||
| c.argument('no_wait', options_list=['--no-wait'], arg_group='Timeout', help="Do not wait for the long-running operation to finish.") | |||
| c.argument('correlation_id', options_list=['--correlation-id'], help='A guid that is used to internally track the source of cluster onboarding. Please do not modify it unless advised', validator=override_client_request_id_header) | |||
| c.argument('container_log_path', help='Override the default container log path to enable fluent-bit logging') | |||
| c.argument('skip_ssl_verification', options_list=['--skip-ssl-verification'], action='store_true', help='Skip SSL verification for any cluster connection.') | |||
There was a problem hiding this comment.
In fact, the default option name does not need to be defined repeatedly
Suggested change
| c.argument('skip_ssl_verification', options_list=['--skip-ssl-verification'], action='store_true', help='Skip SSL verification for any cluster connection.') | |
| c.argument('skip_ssl_verification', action='store_true', help='Skip SSL verification for any cluster connection.') |
There was a problem hiding this comment.
Thanks for the pointer, I updated the argument definitions.
zhoxing-ms
approved these changes
Apr 19, 2024
|
[Release] Update index.json for extension [ connectedk8s ] : https://dev.azure.com/azclitools/release/_build/results?buildId=150393&view=results |
blackchoey
pushed a commit
to blackchoey/azure-cli-extensions
that referenced
this pull request
Apr 29, 2024
…p-cluster-ssl-verification flag (Azure#7294)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az connectedk8s
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.