Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial release of managed devops pools #7351

Merged
merged 9 commits into from
Apr 1, 2024

Conversation

ajaykn
Copy link
Contributor

@ajaykn ajaykn commented Mar 5, 2024


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

Validation for Breaking Change Starting...

Thanks for your contribution!

@yonzhan
Copy link
Collaborator

yonzhan commented Mar 5, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

@ajaykn
Copy link
Contributor Author

ajaykn commented Mar 5, 2024

Currently its in draft, since we want to check the command naming conventions within the team.

Update:

Marked for review.

Was facing issue with delete operation but the latest aaz-dev tools resolved it via Azure/aaz-dev-tools#334

@ajaykn ajaykn marked this pull request as ready for review March 26, 2024 08:44
Copy link

⚠️ Suggestions

Module: mdp

  • Update version to 1.0.0b1 in setup.py

Notes

  • Stable/preview tag is inherited from last release. If needed, please add stable/preview label to modify it.
  • Major/minor/patch/pre increment of version number is calculated by pull request code changes automatically. If needed, please add major/minor/patch/pre label to adjust it.
  • For more info about extension versioning, please refer to Extension version schema

@jsntcy
Copy link
Member

jsntcy commented Mar 27, 2024

@AllyW, @necusjz, please help review.

)
class Update(AAZCommand):
"""Update a Pool
"""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add example for update cmd

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, added. can you please check

@wangzelin007 wangzelin007 merged commit 4eefd69 into Azure:main Apr 1, 2024
15 checks passed
@azclibot
Copy link
Collaborator

azclibot commented Apr 1, 2024

[Release] Update index.json for extension [ mdp ] : https://dev.azure.com/azclitools/release/_build/results?buildId=145121&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants