Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default ACS generation to Gen2 #7368

Merged
merged 2 commits into from
Mar 13, 2024

Conversation

moarychan
Copy link
Member

@moarychan moarychan commented Mar 11, 2024


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

Change the ACS generation to Gen2 when enabling ACS, spring create enable_application_configuration_service

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Mar 11, 2024

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

Copy link

Hi @moarychan,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Mar 11, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

@moarychan moarychan marked this pull request as ready for review March 11, 2024 01:55
@moarychan
Copy link
Member Author

@yuwzho , please help to review this PR, thanks!

Copy link

⚠️ Suggestions

Module: spring

  • Update version to 1.19.5 in setup.py

Notes

  • Stable/preview tag is inherited from last release. If needed, please add stable/preview label to modify it.
  • Major/minor/patch/pre increment of version number is calculated by pull request code changes automatically. If needed, please add major/minor/patch/pre label to adjust it.
  • For more info about extension versioning, please refer to Extension version schema

src/spring/HISTORY.md Outdated Show resolved Hide resolved
@yanzhudd yanzhudd merged commit e72b50d into Azure:main Mar 13, 2024
14 of 15 checks passed
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ spring ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=139056&view=results

@moarychan moarychan deleted the moary/default-acs-generation-to-gen2 branch May 22, 2024 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants