2024-01-01-preview #7392

jamesfan1 · 2024-03-19T00:58:10Z

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
My extension version conforms to the Extension version schema

For new extensions:

My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

azure-client-tools-bot-prd · 2024-03-19T00:58:12Z

❌Azure CLI Extensions Breaking Change Test

❌nginx

rule cmd_name rule_message suggest_message

❌ 1007 - ParaRemove nginx deployment configuration analyze cmd nginx deployment configuration analyze removed parameter config please add back parameter config for cmd nginx deployment configuration analyze

⚠️ 1006 - ParaAdd nginx deployment configuration analyze cmd nginx deployment configuration analyze added parameter files

⚠️ 1006 - ParaAdd nginx deployment configuration analyze cmd nginx deployment configuration analyze added parameter package

⚠️ 1006 - ParaAdd nginx deployment configuration analyze cmd nginx deployment configuration analyze added parameter protected_files

⚠️ 1006 - ParaAdd nginx deployment configuration analyze cmd nginx deployment configuration analyze added parameter root_file

⚠️ 1001 - CmdAdd nginx deployment configuration update cmd nginx deployment configuration update added

⚠️ 1006 - ParaAdd nginx deployment create cmd nginx deployment create added parameter auto_upgrade_profile

⚠️ 1006 - ParaAdd nginx deployment update cmd nginx deployment update added parameter auto_upgrade_profile

azure-client-tools-bot-prd · 2024-03-19T00:58:16Z

Hi @jamesfan1,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

yonzhan · 2024-03-19T00:58:24Z

Thank you for your contribution! We will review the pull request and get back to you soon.

github-actions · 2024-03-19T03:24:40Z

⚠️ Suggestions

Module: nginx

Update version to 2.0.0b1 in setup.py

Notes

Stable/preview tag is inherited from last release. If needed, please add stable/preview label to modify it.
Major/minor/patch/pre increment of version number is calculated by pull request code changes automatically. If needed, please add major/minor/patch/pre label to adjust it.
For more info about extension versioning, please refer to Extension version schema

puneetsarna · 2024-03-26T19:40:14Z

src/nginx/azext_nginx/aaz/latest/nginx/deployment/_create.py

+
+        capacity = cls._args_schema.scaling_properties.profiles.Element.capacity
+        capacity.max = AAZIntArg(
+            options=["max"],


I am not sure how this looks like on Azure CLI but "min" and "max" are not good names as they don't tell the user much about what the min and max are about or applied to.

--scaling-properties profiles=[{name:default,capacity:{min:10,max:30}}]
perhaps if we add this sample in the help command it should explain it?

puneetsarna · 2024-03-26T19:41:32Z

src/nginx/azext_nginx/aaz/latest/nginx/deployment/_create.py

@@ -143,6 +148,13 @@ def _build_arguments_schema(cls, *args, **kwargs):
            help={"short-summary": "Optional: Preferred communication email", "long-summary": "Usage --user-profile [email protected]"},
        )

+        auto_upgrade_profile = cls._args_schema.auto_upgrade_profile
+        auto_upgrade_profile.upgrade_channel = AAZStrArg(


is there a way to add some "help" around valid values? If so, can you please add preview and stable

jamesfan1 · 2024-03-27T22:23:27Z

tests are passing locally, not sure why it doesnt pass in the pipeline. All new command tested manually and succeeding

yonzhan · 2024-03-27T23:40:47Z

Please fix CI issues

AllyW · 2024-03-28T03:38:46Z

⚠️ Suggestions

Module: nginx

Update version to 2.0.0b1 in setup.py

Notes

Stable/preview tag is inherited from last release. If needed, please add stable/preview label to modify it.

Major/minor/patch/pre increment of version number is calculated by pull request code changes automatically. If needed, please add major/minor/patch/pre label to adjust it.

For more info about extension versioning, please refer to Extension version schema

@jamesfan1 there is a breaking change in this pr which deleted a parameter. If it's unintentional, please fix it, if it is intented, that's ok.

Another problem is the version number, the last released version is 1.0.0, since there is a breaking change, so the next release version would be 2.0.0. And if you plan to release a preview version, it should be 2.0.0b1. 1.0.0b1 is smaller than 1.0.0 and we should not release an older version than current one.

For version details, please refer to our doc here

AllyW · 2024-03-28T08:35:16Z

src/nginx/HISTORY.rst

@@ -3,6 +3,10 @@
 Release History
 ===============

+1.0.0b1


please correct version number

fixed, thank you

jamesfan1 · 2024-03-28T08:54:26Z

@AllyW

I am unsure what is wrong for
Azure.azure-cli-extensions Integration test

it is passing locally, and generated a recording file

however, on ci it's failing with

ERROR cli.azure.cli.core.azclierror:azlogging.py:212 Can't overwrite existing cassette ('/mnt/vss/_work/1/s/src/nginx/azext_nginx/tests/latest/recordings/test_deployment_cert_config.yaml') in your current record mode ('once').

on this line, but this line runs fine locally
public_ip = self.cmd('network public-ip create --resource-group {rg} --name {public_ip_name} --version IPv4 --sku Standard --zone 2').get_output_in_json()

have you seen such error?

…ture-2024-01-01-preview

jsntcy · 2024-03-29T08:15:01Z

src/nginx/azext_nginx/azext_metadata.json

@@ -1,3 +1,3 @@
 {
-    "azext.minCliCoreVersion": "2.55.0"
+    "azext.minCliCoreVersion": "2.58.0"


Please set azext.isPreview to true as you will release it as preview.

jamesfan1 · 2024-03-29T18:05:34Z

added the tag, please merge when possible. Thank you all for the help!!
@jsntcy @AllyW

2024-01-01-preview

7f48e09

azure-client-tools-bot-prd bot added this to the March 2024 (2024-04-02) milestone Mar 19, 2024

yonzhan requested a review from jsntcy March 19, 2024 01:11

yonzhan assigned jsntcy Mar 19, 2024

AllyW added the auto-cal-version label Mar 19, 2024

test

35c70f6

puneetsarna reviewed Mar 26, 2024

View reviewed changes

jamesfan1 added 4 commits March 27, 2024 10:30

added fix

546a0f4

updated test

70aaeab

changed version

68b9b56

added history

120d334

jsntcy requested review from AllyW, necusjz and ReaNAiveD March 28, 2024 03:02

AllyW added the preview release extension module as preview label Mar 28, 2024

jamesfan1 added 2 commits March 28, 2024 01:24

change region

9b378f9

added help

d0ca3b0

AllyW reviewed Mar 28, 2024

View reviewed changes

versioning fix

a2ec890

jamesfan1 added 3 commits March 28, 2024 02:13

changed name

ece8f63

added test

fda87c7

set flag

d92e287

jamesfan1 added 8 commits March 28, 2024 10:50

test version

72e47a7

updated test

0d35708

new test

9bc0e3e

test

9bd9633

testing

a5fb165

Merge branch 'main' of github.com:Azure/azure-cli-extensions into fea…

257e67b

…ture-2024-01-01-preview

use non euaop

6ace179

added update

3dcf492

AllyW approved these changes Mar 29, 2024

View reviewed changes

jsntcy reviewed Mar 29, 2024

View reviewed changes

jsntcy approved these changes Mar 29, 2024

View reviewed changes

added preview tag

4244ea2

wangzelin007 approved these changes Apr 1, 2024

View reviewed changes

wangzelin007 merged commit 8250be4 into Azure:main Apr 1, 2024
15 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

2024-01-01-preview #7392

2024-01-01-preview #7392

jamesfan1 commented Mar 19, 2024 •

edited

Loading

azure-client-tools-bot-prd bot commented Mar 19, 2024 •

edited

Loading

azure-client-tools-bot-prd bot commented Mar 19, 2024

yonzhan commented Mar 19, 2024

github-actions bot commented Mar 19, 2024 •

edited

Loading

puneetsarna Mar 26, 2024

jamesfan1 Mar 27, 2024 •

edited

Loading

puneetsarna Mar 26, 2024

jamesfan1 Mar 27, 2024

jamesfan1 commented Mar 27, 2024 •

edited

Loading

yonzhan commented Mar 27, 2024

AllyW commented Mar 28, 2024

⚠️ Suggestions

Module: nginx

Notes

AllyW Mar 28, 2024

jamesfan1 Mar 28, 2024

jamesfan1 commented Mar 28, 2024

jsntcy Mar 29, 2024

jamesfan1 commented Mar 29, 2024

2024-01-01-preview #7392

2024-01-01-preview #7392

Conversation

jamesfan1 commented Mar 19, 2024 • edited Loading

Related command

General Guidelines

About Extension Publish

azure-client-tools-bot-prd bot commented Mar 19, 2024 • edited Loading

azure-client-tools-bot-prd bot commented Mar 19, 2024

yonzhan commented Mar 19, 2024

github-actions bot commented Mar 19, 2024 • edited Loading

⚠️ Suggestions

Module: nginx

Notes

puneetsarna Mar 26, 2024

Choose a reason for hiding this comment

jamesfan1 Mar 27, 2024 • edited Loading

Choose a reason for hiding this comment

puneetsarna Mar 26, 2024

Choose a reason for hiding this comment

jamesfan1 Mar 27, 2024

Choose a reason for hiding this comment

jamesfan1 commented Mar 27, 2024 • edited Loading

yonzhan commented Mar 27, 2024

AllyW commented Mar 28, 2024

⚠️ Suggestions

Module: nginx

Notes

AllyW Mar 28, 2024

Choose a reason for hiding this comment

jamesfan1 Mar 28, 2024

Choose a reason for hiding this comment

jamesfan1 commented Mar 28, 2024

jsntcy Mar 29, 2024

Choose a reason for hiding this comment

jamesfan1 commented Mar 29, 2024

jamesfan1 commented Mar 19, 2024 •

edited

Loading

azure-client-tools-bot-prd bot commented Mar 19, 2024 •

edited

Loading

github-actions bot commented Mar 19, 2024 •

edited

Loading

jamesfan1 Mar 27, 2024 •

edited

Loading

jamesfan1 commented Mar 27, 2024 •

edited

Loading