Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Container app] az containerapp connected-env certificate upload: Fix unknown properties certificateKeyVaultProperties #7394

Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/containerapp/HISTORY.rst
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ Release History
===============
upcoming
++++++
* 'az containerapp connected-env certificate upload': Fix unknown properties certificateKeyVaultProperties

0.3.49
++++++
Expand Down
8 changes: 8 additions & 0 deletions src/containerapp/azext_containerapp/_models.py
Original file line number Diff line number Diff line change
Expand Up @@ -388,6 +388,14 @@
}
}

ContainerAppConnectedEnvironmentCertificateEnvelope = {
"location": None,
"properties": {
"password": None,
"value": None,
}
}

DaprComponent = {
"properties": {
"componentType": None, # str
Expand Down
4 changes: 2 additions & 2 deletions src/containerapp/azext_containerapp/custom.py
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@
RegistryInfo as RegistryInfoModel,
AzureCredentials as AzureCredentialsModel,
SourceControl as SourceControlModel,
ContainerAppCertificateEnvelope as ContainerAppCertificateEnvelopeModel,
ContainerAppConnectedEnvironmentCertificateEnvelope as ContainerAppConnectedEnvironmentCertificateEnvelopeModel,
AzureFileProperties as AzureFilePropertiesModel
)

Expand Down Expand Up @@ -1893,7 +1893,7 @@ def connected_env_upload_certificate(cmd, name, resource_group_name, certificate
elif not check_result["nameAvailable"] and (check_result["reason"] == NAME_INVALID):
raise ValidationError(check_result["message"])

certificate = ContainerAppCertificateEnvelopeModel
certificate = ContainerAppConnectedEnvironmentCertificateEnvelopeModel
certificate["properties"]["password"] = certificate_password
certificate["properties"]["value"] = blob
certificate["location"] = location
Expand Down
Loading
Loading