Release New-Relic CLI for stable version 2024-01-01 #7402

dipeshbhakat-microsoft · 2024-03-21T07:07:17Z

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
My extension version conforms to the Extension version schema

For new extensions:

My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

azure-client-tools-bot-prd · 2024-03-21T07:07:20Z

⚠️Azure CLI Extensions Breaking Change Test

⚠️new-relic

rule cmd_name rule_message suggest_message

⚠️ 1006 - ParaAdd new-relic account list cmd new-relic account list added parameter pagination_limit

⚠️ 1006 - ParaAdd new-relic account list cmd new-relic account list added parameter pagination_token

⚠️ 1001 - CmdAdd new-relic monitor get-billing-info cmd new-relic monitor get-billing-info added

⚠️ 1006 - ParaAdd new-relic monitor list cmd new-relic monitor list added parameter pagination_limit

⚠️ 1006 - ParaAdd new-relic monitor list cmd new-relic monitor list added parameter pagination_token

⚠️ 1006 - ParaAdd new-relic monitor list-app-service cmd new-relic monitor list-app-service added parameter pagination_limit

⚠️ 1006 - ParaAdd new-relic monitor list-app-service cmd new-relic monitor list-app-service added parameter pagination_token

⚠️ 1001 - CmdAdd new-relic monitor list-connected-partner-resource cmd new-relic monitor list-connected-partner-resource added

⚠️ 1006 - ParaAdd new-relic monitor list-host cmd new-relic monitor list-host added parameter pagination_limit

⚠️ 1006 - ParaAdd new-relic monitor list-host cmd new-relic monitor list-host added parameter pagination_token

⚠️ 1001 - CmdAdd new-relic monitor list-linked-resource cmd new-relic monitor list-linked-resource added

⚠️ 1006 - ParaAdd new-relic monitor monitored-resource cmd new-relic monitor monitored-resource added parameter pagination_limit

⚠️ 1006 - ParaAdd new-relic monitor monitored-resource cmd new-relic monitor monitored-resource added parameter pagination_token

⚠️ 1011 - SubgroupAdd new-relic monitor monitored-subscription sub group new-relic monitor monitored-subscription added

⚠️ 1006 - ParaAdd new-relic monitor tag-rule list cmd new-relic monitor tag-rule list added parameter pagination_limit

⚠️ 1006 - ParaAdd new-relic monitor tag-rule list cmd new-relic monitor tag-rule list added parameter pagination_token

⚠️ 1006 - ParaAdd new-relic organization list cmd new-relic organization list added parameter pagination_limit

⚠️ 1006 - ParaAdd new-relic organization list cmd new-relic organization list added parameter pagination_token

⚠️ 1006 - ParaAdd new-relic plan list cmd new-relic plan list added parameter pagination_limit

⚠️ 1006 - ParaAdd new-relic plan list cmd new-relic plan list added parameter pagination_token

azure-client-tools-bot-prd · 2024-03-21T07:07:23Z

Hi @dipeshbhakat-microsoft,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

yonzhan · 2024-03-21T07:07:27Z

Thank you for your contribution! We will review the pull request and get back to you soon.

yonzhan · 2024-03-21T14:39:39Z

Please fix CI issues

jsntcy · 2024-03-25T05:45:20Z

src/new-relic/azext_new_relic/aaz/latest/new_relic/monitor/_create.py

@@ -51,6 +51,8 @@ def _build_arguments_schema(cls, *args, **kwargs):
            required=True,
        )
        _args_schema.resource_group = AAZResourceGroupNameArg(
+            options=["--resource-group"],


It seems this change introduces a breaking change (Previously it supported both "--resource-group" and "--g", but now it only supports "--resource-group"). Please check other breaking changes as well.

Thanks @jsntcy for pointing out. I think this is not expected. I will revert this change. We should be able to support both "--resource-group" and "--g"

@jsntcy I have reverted the changes which were breaking changes. Please have a look if anything else is breaking.

@dipeshbhakat-microsoft still two?

I have now added the remaining test cases and fixed the breaking changes.
We can merge if everything gets approved

@necusjz all work from my side is done now. Let me know if anything else is required from my side. Also please remove do not merge tag. We can merge now if the PR gets approved.

jsntcy · 2024-03-25T05:49:30Z

❌Azure CLI Extensions Breaking Change Test

@dipeshbhakat-microsoft,
It seems there are lots of breaking changes introduced by this PR and I think many are unexpected, for example previously supported both "--resource-group" and "--g", but now only support "--resource-group".
If you do want those breaking changes, you need release them in breaking change window.

@necusjz, @AllyW, please help confirm.

github-actions · 2024-03-27T05:52:59Z

⚠️ Suggestions

Module: new-relic

Update version to 1.0.0b2 in setup.py
Set azext.isPreview to true in azext_new-relic/azext_metadata.json if not exists

Notes

Stable/preview tag is inherited from last release. If needed, please add stable/preview label to modify it.
Major/minor/patch/pre increment of version number is calculated by pull request code changes automatically. If needed, please add major/minor/patch/pre label to adjust it.
For more info about extension versioning, please refer to Extension version schema

dipeshbhakat-microsoft · 2024-03-27T07:22:07Z

⚠️ Suggestions

Module: new-relic

Update version to 1.0.0b2 in setup.py

Set azext.isPreview to true in azext_new-relic/azext_metadata.json if not exists

Notes

Stable/preview tag is inherited from last release. If needed, please add stable/preview label to modify it.

Major/minor/patch/pre increment of version number is calculated by pull request code changes automatically. If needed, please add major/minor/patch/pre label to adjust it.

For more info about extension versioning, please refer to Extension version schema

This is a stable version release so updated the version to 1.0.0 and removed azext.isPreview = true from azext_new-relic/azext_metadata.json.

Please let me know if anything else is required

dipeshbhakat-microsoft · 2024-03-31T05:27:26Z

@jsntcy @necusjz can we please approve and merge it if anything is not pending.

dipeshbhakat-microsoft · 2024-04-05T04:09:48Z

@kairu-ms / @jsntcy can we please remove do-not-merge lable and complete the review. Its pending from long.

kairu-ms

LGTM

azclibot · 2024-04-08T04:32:27Z

[Release] Update index.json for extension [ new-relic ] : https://dev.azure.com/azclitools/release/_build/results?buildId=146406&view=results

* NewRelic CLI refresh * fix issues found in manual testing * Fix tag rules commands * Update command for monitored-subscription * Update history and version number * use short abbreviation for monitored_subscription_list * Delete recordings and fix flake8 issues * Remove default value from configuration-name * fix tests * Fix tests and remove unused reference * Fix issues * Fix all integration tests * Add monitored subscription test cases * remove commented test cases * Remove trailling whitespace * Undo breaking changes * Revert get-metric-status to get-metric-statu * Add more test cases and fix breaking changes * Fix GetMetric Status breaking change * Fix ingestionkey secret in recordings * Update changelog to trigger build again * Use Production region to run tests as partner staging is not working * Fix build * Attempt to fix build * Fix versioning

NewRelic CLI refresh

3fecebe

dipeshbhakat-microsoft requested a review from necusjz as a code owner March 21, 2024 07:07

azure-client-tools-bot-prd bot added this to the March 2024 (2024-04-02) milestone Mar 21, 2024

fix issues found in manual testing

1b8c3c7

dipeshbhakat-microsoft marked this pull request as draft March 21, 2024 07:17

yonzhan assigned jsntcy Mar 21, 2024

yonzhan requested a review from jsntcy March 21, 2024 09:08

Fix tag rules commands

72bda21

dipeshbhakat-microsoft changed the title ~~NewRelic CLI refresh~~ Release for New-Relic CLI for stable version 2024-01-01 Mar 21, 2024

dipeshbhakat-microsoft changed the title ~~Release for New-Relic CLI for stable version 2024-01-01~~ Release New-Relic CLI for stable version 2024-01-01. Mar 21, 2024

Update command for monitored-subscription

aaaa893

dipeshbhakat-microsoft marked this pull request as ready for review March 21, 2024 12:54

Update history and version number

3b4eaa5

dipeshbhakat-microsoft added 10 commits March 22, 2024 09:42

use short abbreviation for monitored_subscription_list

ca3e764

Delete recordings and fix flake8 issues

70be756

Remove default value from configuration-name

3a36591

fix tests

dd48bc8

Fix tests and remove unused reference

b20ae0a

Fix issues

aea2c1c

Fix all integration tests

76d2084

Add monitored subscription test cases

87acc1d

remove commented test cases

04c543c

Remove trailling whitespace

5996377

jsntcy reviewed Mar 25, 2024

View reviewed changes

jsntcy requested a review from AllyW March 25, 2024 05:49

jsntcy requested a review from ReaNAiveD March 25, 2024 05:49

jsntcy assigned necusjz Mar 25, 2024

Undo breaking changes

b013ecd

dipeshbhakat-microsoft requested a review from jsntcy March 26, 2024 05:48

dipeshbhakat-microsoft changed the title ~~Release New-Relic CLI for stable version 2024-01-01.~~ Release New-Relic CLI for stable version 2024-01-01(Please don't merge it, addition of 2 test cases pending) Mar 26, 2024

necusjz added the do-not-merge label Mar 26, 2024

Revert get-metric-status to get-metric-statu

21ffd51

dipeshbhakat-microsoft changed the title ~~Release New-Relic CLI for stable version 2024-01-01(Please don't merge it, addition of 2 test cases pending)~~ Release New-Relic CLI for stable version 2024-01-01 Mar 26, 2024

dipeshbhakat-microsoft added 6 commits March 26, 2024 14:44

Add more test cases and fix breaking changes

40573ee

Fix GetMetric Status breaking change

b81c94c

Fix ingestionkey secret in recordings

a6e0d85

Update changelog to trigger build again

396d188

Use Production region to run tests as partner staging is not working

85a39c5

Fix build

bcc1242

dipeshbhakat-microsoft force-pushed the features/users/dipeshbhakat/nrclirefresh branch from dc2ecb7 to bcc1242 Compare March 26, 2024 10:52

Attempt to fix build

f1e5a6f

AllyW added the auto-cal-version label Mar 27, 2024

Fix versioning

da3a3e1

jsntcy requested a review from kairu-ms April 2, 2024 05:13

kairu-ms approved these changes Apr 8, 2024

View reviewed changes

kairu-ms removed the do-not-merge label Apr 8, 2024

kairu-ms merged commit 7429e7a into Azure:main Apr 8, 2024
17 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release New-Relic CLI for stable version 2024-01-01 #7402

Release New-Relic CLI for stable version 2024-01-01 #7402

dipeshbhakat-microsoft commented Mar 21, 2024 •

edited

Loading

azure-client-tools-bot-prd bot commented Mar 21, 2024 •

edited

Loading

azure-client-tools-bot-prd bot commented Mar 21, 2024

yonzhan commented Mar 21, 2024

yonzhan commented Mar 21, 2024

jsntcy Mar 25, 2024

dipeshbhakat-microsoft Mar 26, 2024 •

edited

Loading

dipeshbhakat-microsoft Mar 26, 2024

necusjz Mar 26, 2024

dipeshbhakat-microsoft Mar 26, 2024 •

edited

Loading

dipeshbhakat-microsoft Mar 26, 2024 •

edited

Loading

jsntcy commented Mar 25, 2024

github-actions bot commented Mar 27, 2024

dipeshbhakat-microsoft commented Mar 27, 2024

⚠️ Suggestions

Module: new-relic

Notes

dipeshbhakat-microsoft commented Mar 31, 2024

dipeshbhakat-microsoft commented Apr 5, 2024

kairu-ms left a comment

azclibot commented Apr 8, 2024

Release New-Relic CLI for stable version 2024-01-01 #7402

Release New-Relic CLI for stable version 2024-01-01 #7402

Conversation

dipeshbhakat-microsoft commented Mar 21, 2024 • edited Loading

Related command

General Guidelines

About Extension Publish

azure-client-tools-bot-prd bot commented Mar 21, 2024 • edited Loading

azure-client-tools-bot-prd bot commented Mar 21, 2024

yonzhan commented Mar 21, 2024

yonzhan commented Mar 21, 2024

jsntcy Mar 25, 2024

Choose a reason for hiding this comment

dipeshbhakat-microsoft Mar 26, 2024 • edited Loading

Choose a reason for hiding this comment

dipeshbhakat-microsoft Mar 26, 2024

Choose a reason for hiding this comment

necusjz Mar 26, 2024

Choose a reason for hiding this comment

dipeshbhakat-microsoft Mar 26, 2024 • edited Loading

Choose a reason for hiding this comment

dipeshbhakat-microsoft Mar 26, 2024 • edited Loading

Choose a reason for hiding this comment

jsntcy commented Mar 25, 2024

github-actions bot commented Mar 27, 2024

⚠️ Suggestions

Module: new-relic

Notes

dipeshbhakat-microsoft commented Mar 27, 2024

⚠️ Suggestions

Module: new-relic

Notes

dipeshbhakat-microsoft commented Mar 31, 2024

dipeshbhakat-microsoft commented Apr 5, 2024

kairu-ms left a comment

Choose a reason for hiding this comment

azclibot commented Apr 8, 2024

dipeshbhakat-microsoft commented Mar 21, 2024 •

edited

Loading

azure-client-tools-bot-prd bot commented Mar 21, 2024 •

edited

Loading

dipeshbhakat-microsoft Mar 26, 2024 •

edited

Loading

dipeshbhakat-microsoft Mar 26, 2024 •

edited

Loading

dipeshbhakat-microsoft Mar 26, 2024 •

edited

Loading