Email services domain initiate and cancel verification changes #7404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| communication email domain cancel-verification | cmd communication email domain cancel-verification added |
||
| communication email domain initiate-verification | cmd communication email domain initiate-verification added |
|
Hi @v-vprasannak, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
microsoft-github-policy-service
bot
added
the
customer-reported
|
|
…s://github.com/v-vprasannak/azure-cli-extensions into EmailServicesDomain-InitiateCancelVerification
kairu-ms
reviewed
Apr 8, 2024
Comment on lines
20
to
22
| :example: Get all resources from a subscription/resource group | ||
| az communication email list --subscription SubscriptionId | ||
| az communication email list -g ResourceGroup |
There was a problem hiding this comment.
actually the --subscription is optional. The command will use login subscription as default. BTW, we usually separate it into two examples like this:
Suggested change
| :example: Get all resources from a subscription/resource group | |
| az communication email list --subscription SubscriptionId | |
| az communication email list -g ResourceGroup | |
| :example: Get all resources from a subscription | |
| az communication email list --subscription SubscriptionId | |
| :example: Get all resources from a resource group | |
| az communication email list -g ResourceGroup |
There was a problem hiding this comment.
separated examples as suggested.
kairu-ms
approved these changes
Apr 9, 2024
|
[Release] Update index.json for extension [ communication ] : https://dev.azure.com/azclitools/release/_build/results?buildId=146812&view=results |
blackchoey
pushed a commit
to blackchoey/azure-cli-extensions
that referenced
this pull request
Apr 29, 2024
…#7404) * EmailServiceDomain Initiate and cancel verification * Email service domain initiate cancel verification changes version update * EmailServiceDomain Initiate and cancel verification - resolving version conflicts * EmailService Domain - Initiate and Cancel verification * Email Service -Domain - Sender username- Added examples * Email Service - updated list example command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.