Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Communication Service]Add managed identity to ACS cli extension #7407

Merged

Conversation

Joeleniqs
Copy link
Member


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Mar 22, 2024

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

Copy link

Hi @Joeleniqs,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Mar 22, 2024

Communication Service

@FumingZhang FumingZhang removed their request for review March 22, 2024 02:33
Copy link

github-actions bot commented Mar 27, 2024

⚠️ Suggestions

Module: communication

  • Update version to 1.8.0 in setup.py

Notes

  • Stable/preview tag is inherited from last release. If needed, please add stable/preview label to modify it.
  • Major/minor/patch/pre increment of version number is calculated by pull request code changes automatically. If needed, please add major/minor/patch/pre label to adjust it.
  • For more info about extension versioning, please refer to Extension version schema

@AllyW AllyW added the stable release extension module as stable label Mar 27, 2024
@Joeleniqs Joeleniqs marked this pull request as ready for review March 27, 2024 09:07
@yonzhan yonzhan assigned jsntcy and unassigned zhoxing-ms and yanzhudd Mar 27, 2024
@necusjz necusjz merged commit 5394afa into Azure:main Mar 28, 2024
19 checks passed
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ communication ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=144309&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AKS Auto-Assign Auto assign by bot auto-cal-version stable release extension module as stable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants