[ContainerApp] Update Cloud Build code to the ARM simplification #7413
Conversation
️✔️Azure CLI Extensions Breaking Change Test
|
|
Hi @daniv-msft, |
|
ContainerApp |
microsoft-github-policy-service
bot
requested review from
wangzelin007,
yanzhudd,
zhoxing-ms,
jsntcy,
ruslany,
sanchitmehta,
ebencarek,
JennyLawrance,
howang-ms,
vinisoto,
chinadragon0515,
vturecek,
torosent,
pagariyaalok,
Juliehzl,
jijohn14 and
Greedygre
|
Tagging @harryli0108 for FYI |
|
@harryli0108 Could you please take care of updating/merging this PR from there as I won't be there to do so? |
|
|
Please note that Azure CLI team is only responsible for code style and specification, but not business logic. It would be better to involve the service team to review this PR first. |
|
Please add test for this change to check if it can meet your expectation. |
|
How may get support in these issues? If there is an opportunity to help me that will be highly appreciated. Kind Regards |
| @@ -11,6 +11,7 @@ upcoming | |||
| * 'az containerapp env telemetry otlp remove': Support remove environment otlp configuration with --otlp-name | |||
| * 'az containerapp env telemetry otlp show': Support show environment otlp configuration with --otlp-name | |||
| * 'az containerapp env telemetry otlp list': Support show environment otlp configurations | |||
| * 'az containerapp up/create/update': Update Cloud Build code to use the simplified ARM calling pattern | |||
There was a problem hiding this comment.
Please move this to upcoming
|
Please get approval from your team who could be responsible for your business logic firstly. |
| archive_source_code(data_file_path, source) | ||
| done_spinner = True | ||
| thread.join() | ||
|
|
||
| # File upload | ||
| done_spinner = False | ||
| thread = display_spinner("Uploading data") | ||
| container_app_id = container_app_result["id"] | ||
| base_proxy_endpoint = container_app_result["properties"]["eventStreamEndpoint"].rstrip("/eventstream") | ||
| upload_endpoint = base_proxy_endpoint + f"/upload?token={token}" |
There was a problem hiding this comment.
Here can be:
upload_endpoint =f"{base_proxy_endpoint}/upload?token={token}"
| @@ -159,6 +157,9 @@ def spin(): | |||
| os.unlink(data_file_path) | |||
| if not response_file_upload.ok: | |||
| raise ValidationError(f"Error when uploading the file, request exited with {response_file_upload.status_code}") | |||
| file_upload_json = response_file_upload.json() | |||
| build_name = file_upload_json["name"] | |||
| log_streaming_endpoint = base_proxy_endpoint + f"/builds/{build_name}/logstream" | |||
|
Hi @Moazzem-Hossain-pixel Please rerun related tests to make sure e2e tests can pass. You can update the related recording files or paste your test rerun result in the description. |
Run related test with command: |
|
Continuing to contribute to this change in a new PR #7522. Please feel free to close this PR if needed |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az containerapp up
az containerapp create
az containerapp update
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.