Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[confcom] Adding new flag for faster hashing and patching tar file usage #7414

Merged
merged 6 commits into from
Apr 1, 2024

Conversation

SethHollandsworth
Copy link
Contributor

Docker changed how tar files are formatted so this is adding compatibility for the new format. Also adding a flag to hash images faster to the detriment of more RAM usage.


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az confcom

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Mar 25, 2024

⚠️Azure CLI Extensions Breaking Change Test
⚠️confcom
rule cmd_name rule_message suggest_message
⚠️ 1006 - ParaAdd confcom acipolicygen cmd confcom acipolicygen added parameter faster_hashing

Copy link

Hi @SethHollandsworth,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

@yonzhan
Copy link
Collaborator

yonzhan commented Mar 25, 2024

confcom

Copy link

⚠️ Suggestions

Module: confcom

  • Update version to 1.0.0 in setup.py

Notes

  • Stable/preview tag is inherited from last release. If needed, please add stable/preview label to modify it.
  • Major/minor/patch/pre increment of version number is calculated by pull request code changes automatically. If needed, please add major/minor/patch/pre label to adjust it.
  • For more info about extension versioning, please refer to Extension version schema

@kairu-ms kairu-ms merged commit f9a35f7 into Azure:main Apr 1, 2024
17 checks passed
@azclibot
Copy link
Collaborator

azclibot commented Apr 1, 2024

[Release] Update index.json for extension [ confcom ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=144952&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants