Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Windows platform check and refactor structure definitions in azex… #7426

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ereli-sevenai
Copy link

This PR introduces a crucial check to ensure the azext_ssh module runs only on Windows platforms, preventing import errors on non-Windows systems.

Copy link

azure-client-tools-bot-prd bot commented Mar 27, 2024

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

Copy link

Hi @ereli-okami,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

Copy link

Hi @ereli-okami,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

Copy link
Contributor

Thank you for your contribution ereli-okami! We will review the pull request and get back to you soon.

@microsoft-github-policy-service microsoft-github-policy-service bot added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Mar 27, 2024
@yonzhan
Copy link
Collaborator

yonzhan commented Mar 27, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

@ereli-sevenai
Copy link
Author

@microsoft-github-policy-service agree [company="Okami AI"]

@ereli-sevenai
Copy link
Author

@microsoft-github-policy-service agree company="Okami AI"

Copy link

github-actions bot commented Apr 1, 2024

⚠️ Suggestions

Module: ssh

  • Update version to 2.0.4 in setup.py

Notes

  • Stable/preview tag is inherited from last release. If needed, please add stable/preview label to modify it.
  • Major/minor/patch/pre increment of version number is calculated by pull request code changes automatically. If needed, please add major/minor/patch/pre label to adjust it.
  • For more info about extension versioning, please refer to Extension version schema

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-cal-version customer-reported Issues that are reported by GitHub users external to the Azure organization.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants