-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Standby pool cli #7430
Create Standby pool cli #7430
Conversation
Validation for Breaking Change Starting...
Thanks for your contribution! |
Hi @fangru2023, |
Hi @fangru2023, |
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
Done |
@jsntcy , any feedback? Need review @yonzhan, @zhoxing-ms , @kairu-ms |
@jsntcy,@yonzhan, @zhoxing-ms , @kairu-ms I believe we are ready for review. Will need to get this merged this week so we can meet CLI may launch. |
Hi @kairu-ms, thanks for your reviewing, addressed your comments and publish a newer iteration, now it's ready to review again. |
PR approved. @fangru2023, is it ready for the first release. |
@kairu-ms I believe we are ready for merge. CC @fangru2023 |
Yep, @kairu-ms, it's ready for the first release! Thanks for approval! |
[Release] Update index.json for extension [ standbypool ] : https://dev.azure.com/azclitools/release/_build/results?buildId=151833&view=results |
* add standbypool. * fix commands. * fix cli. * remove sub. * update. * address comments. * address comments.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az standby-vm-pool create
az standby-vm-pool update
az standby-vm-pool show
az standby-vm-pool list
az standby-vm-pool delete
az standby-container-group-pool create
az standby-container-group-pool show
az standby-container-group-pool list
az standby-container-group-pool delete
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally? (pip install wheel==0.30.0
required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.json
automatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json
.