Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Standby pool cli #7430

Merged
merged 7 commits into from
Apr 23, 2024
Merged

Create Standby pool cli #7430

merged 7 commits into from
Apr 23, 2024

Conversation

fangru2023
Copy link
Member

@fangru2023 fangru2023 commented Mar 29, 2024


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az standby-vm-pool create
az standby-vm-pool update
az standby-vm-pool show
az standby-vm-pool list
az standby-vm-pool delete

az standby-container-group-pool create
az standby-container-group-pool show
az standby-container-group-pool list
az standby-container-group-pool delete

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

Validation for Breaking Change Starting...

Thanks for your contribution!

Copy link

Hi @fangru2023,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

Copy link

Hi @fangru2023,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

@yonzhan
Copy link
Collaborator

yonzhan commented Mar 29, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link

github-actions bot commented Apr 1, 2024

⚠️ Release Suggestions

Module: standbypool

  • Update version to 1.0.0b1 in setup.py

Notes

  • Stable/preview tag is inherited from last release. If needed, please add stable/preview label to modify it.
  • Major/minor/patch/pre increment of version number is calculated by pull request code changes automatically. If needed, please add major/minor/patch/pre label to adjust it.
  • For more info about extension versioning, please refer to Extension version schema

@fangru2023 fangru2023 marked this pull request as ready for review April 1, 2024 18:20
@mimckitt
Copy link

mimckitt commented Apr 8, 2024

@yonzhan @jsntcy any update on this? Anything you need from us?

@fangru2023
Copy link
Member Author

⚠️ Suggestions

Module: standbypool

  • Update version to 1.0.0b1 in setup.py

Notes

  • Stable/preview tag is inherited from last release. If needed, please add stable/preview label to modify it.
  • Major/minor/patch/pre increment of version number is calculated by pull request code changes automatically. If needed, please add major/minor/patch/pre label to adjust it.
  • For more info about extension versioning, please refer to Extension version schema

Done

@fangru2023
Copy link
Member Author

fangru2023 commented Apr 20, 2024

@jsntcy , any feedback?

Need review @yonzhan, @zhoxing-ms , @kairu-ms
cc: @bxubxu , @mimckitt, [email protected]

@mimckitt
Copy link

@jsntcy,@yonzhan, @zhoxing-ms , @kairu-ms

I believe we are ready for review. Will need to get this merged this week so we can meet CLI may launch.

src/standbypool/README.md Outdated Show resolved Hide resolved
src/service_name.json Outdated Show resolved Hide resolved
@fangru2023
Copy link
Member Author

Hi @kairu-ms, thanks for your reviewing, addressed your comments and publish a newer iteration, now it's ready to review again.

@kairu-ms
Copy link
Contributor

PR approved. @fangru2023, is it ready for the first release.

@mimckitt
Copy link

@kairu-ms I believe we are ready for merge.

CC @fangru2023

@fangru2023
Copy link
Member Author

PR approved. @fangru2023, is it ready for the first release.

Yep, @kairu-ms, it's ready for the first release! Thanks for approval!

@kairu-ms kairu-ms merged commit 02e8832 into Azure:main Apr 23, 2024
15 checks passed
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ standbypool ] : https://dev.azure.com/azclitools/release/_build/results?buildId=151833&view=results

blackchoey pushed a commit to blackchoey/azure-cli-extensions that referenced this pull request Apr 29, 2024
* add standbypool.

* fix commands.

* fix cli.

* remove sub.

* update.

* address comments.

* address comments.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants