Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{AKS} Fix test cases related premium sku #7433

Merged
merged 2 commits into from
Mar 29, 2024

Conversation

FumingZhang
Copy link
Member


This checklist is used to make sure that common guidelines for a pull request are followed.

Fix the following 2 cases

  • test_aks_create_with_premium_sku
  • test_aks_update_with_premium_sku

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Mar 29, 2024

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

Copy link

Hi @FumingZhang,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

Copy link

Hi @FumingZhang,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Mar 29, 2024

AKS

@FumingZhang
Copy link
Member Author

Queued live test to validate the change. Test passed!

@yanzhudd yanzhudd merged commit 4e703dd into Azure:main Mar 29, 2024
20 checks passed
@FumingZhang FumingZhang deleted the fuming/fix-test-premium-sku-0329 branch May 11, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AKS Auto-Assign Auto assign by bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants