Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support shared slb probe #7435

Merged
merged 4 commits into from
Apr 9, 2024
Merged

feat: Support shared slb probe #7435

merged 4 commits into from
Apr 9, 2024

Conversation

nilo19
Copy link
Member

@nilo19 nilo19 commented Mar 29, 2024


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az aks create --cluster-service-load-balancer-health-probe-mode Servicenodeport
az aks create --cluster-service-load-balancer-health-probe-mode Shared
az aks update --cluster-service-load-balancer-health-probe-mode Shared
az aks update --cluster-service-load-balancer-health-probe-mode Servicenodeport

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Mar 29, 2024

⚠️Azure CLI Extensions Breaking Change Test
⚠️aks-preview
rule cmd_name rule_message suggest_message
⚠️ 1006 - ParaAdd aks create cmd aks create added parameter cluster_service_load_balancer_health_probe_mode
⚠️ 1006 - ParaAdd aks update cmd aks update added parameter cluster_service_load_balancer_health_probe_mode

Copy link

Hi @nilo19,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

@yonzhan
Copy link
Collaborator

yonzhan commented Mar 29, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link
Member

@FumingZhang FumingZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Queued live test to validate the newly added test case.

  • test_aks_create_or_update_with_health_probe_mode

Copy link

github-actions bot commented Apr 1, 2024

⚠️ Suggestions

Module: aks-preview

  • Update version to 3.0.0b2 in setup.py
  • Set azext.isPreview to true in azext_aks-preview/azext_metadata.json if not exists

Notes

  • Stable/preview tag is inherited from last release. If needed, please add stable/preview label to modify it.
  • Major/minor/patch/pre increment of version number is calculated by pull request code changes automatically. If needed, please add major/minor/patch/pre label to adjust it.
  • For more info about extension versioning, please refer to Extension version schema

@yanzhudd yanzhudd merged commit 9448fdb into Azure:main Apr 9, 2024
15 checks passed
@nilo19 nilo19 deleted the feat/slb-probe branch April 9, 2024 03:28
blackchoey pushed a commit to blackchoey/azure-cli-extensions that referenced this pull request Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants