-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support shared slb probe #7435
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rule | cmd_name | rule_message | suggest_message |
---|---|---|---|
aks create | cmd aks create added parameter cluster_service_load_balancer_health_probe_mode |
||
aks update | cmd aks update added parameter cluster_service_load_balancer_health_probe_mode |
Hi @nilo19, |
Thank you for your contribution! We will review the pull request and get back to you soon. |
microsoft-github-policy-service
bot
requested review from
zhoxing-ms,
yanzhudd and
yonzhan
March 29, 2024 13:18
FumingZhang
reviewed
Apr 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Queued live test to validate the newly added test case.
- test_aks_create_or_update_with_health_probe_mode
|
FumingZhang
approved these changes
Apr 3, 2024
yanzhudd
reviewed
Apr 8, 2024
yanzhudd
reviewed
Apr 8, 2024
Co-authored-by: Yan Zhu <[email protected]>
Co-authored-by: Yan Zhu <[email protected]>
yanzhudd
approved these changes
Apr 9, 2024
blackchoey
pushed a commit
to blackchoey/azure-cli-extensions
that referenced
this pull request
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az aks create --cluster-service-load-balancer-health-probe-mode Servicenodeport
az aks create --cluster-service-load-balancer-health-probe-mode Shared
az aks update --cluster-service-load-balancer-health-probe-mode Shared
az aks update --cluster-service-load-balancer-health-probe-mode Servicenodeport
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally? (pip install wheel==0.30.0
required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.json
automatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json
.