-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix #7436
Bugfix #7436
Conversation
️✔️Azure CLI Extensions Breaking Change Test
|
Hi @qwuae1, |
Hi @qwuae1, |
Thank you for your contribution! We will review the pull request and get back to you soon. |
/azp run |
Commenter does not have sufficient privileges for PR 7436 in repo Azure/azure-cli-extensions |
@zhoxing-ms |
Please fix CI issues |
src/vm-repair/HISTORY.rst
Outdated
@@ -1,6 +1,9 @@ | |||
|
|||
Release History | |||
=============== | |||
1.0.2 | |||
++++++ | |||
Fix repo branch to main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you explain in detail what this description means?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zhoxing-ms
yeah, the null string check is not working as the string is return empty
now setting the branch to the correct repo
updated the his rst
# For test releases and testing | ||
TEST_KEY = 'a6bdff92-33b5-426f-9123-33875d0ae98b' | ||
PROD_KEY = '3e7130f2-759b-41d4-afb8-f1405d1d7ed9' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to confirm with you whether there is a security risk in exposing these keys to the public in the open source code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
|
Please take a look at this comment: #7436 (comment)
|
thx, resolve it |
[Release] Update index.json for extension [ vm-repair ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=145001&view=results |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally? (pip install wheel==0.30.0
required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.json
automatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json
.