Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix #7436

Merged
merged 12 commits into from
Apr 1, 2024
Merged

Bugfix #7436

merged 12 commits into from
Apr 1, 2024

Conversation

qwuae1
Copy link
Contributor

@qwuae1 qwuae1 commented Mar 29, 2024


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Mar 29, 2024

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

Copy link

Hi @qwuae1,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

Copy link

Hi @qwuae1,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

@yonzhan
Copy link
Collaborator

yonzhan commented Mar 29, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

@qwuae1
Copy link
Contributor Author

qwuae1 commented Mar 29, 2024

/azp run

Copy link

Commenter does not have sufficient privileges for PR 7436 in repo Azure/azure-cli-extensions

@qwuae1
Copy link
Contributor Author

qwuae1 commented Mar 29, 2024

@zhoxing-ms
may you help me with approval and merge

@yonzhan
Copy link
Collaborator

yonzhan commented Mar 29, 2024

Please fix CI issues

@@ -1,6 +1,9 @@

Release History
===============
1.0.2
++++++
Fix repo branch to main
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you explain in detail what this description means?

Copy link
Contributor Author

@qwuae1 qwuae1 Mar 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zhoxing-ms
yeah, the null string check is not working as the string is return empty
now setting the branch to the correct repo

updated the his rst

Comment on lines 31 to 33
# For test releases and testing
TEST_KEY = 'a6bdff92-33b5-426f-9123-33875d0ae98b'
PROD_KEY = '3e7130f2-759b-41d4-afb8-f1405d1d7ed9'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to confirm with you whether there is a security risk in exposing these keys to the public in the open source code?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make this change separated
linter passed locally
image

@qwuae1
Copy link
Contributor Author

qwuae1 commented Apr 1, 2024

Copy link

github-actions bot commented Apr 1, 2024

⚠️ Suggestions

Module: vm-repair

  • Update version to 1.0.2 in setup.py

Notes

  • Stable/preview tag is inherited from last release. If needed, please add stable/preview label to modify it.
  • Major/minor/patch/pre increment of version number is calculated by pull request code changes automatically. If needed, please add major/minor/patch/pre label to adjust it.
  • For more info about extension versioning, please refer to Extension version schema

@zhoxing-ms
Copy link
Contributor

Please take a look at this comment: #7436 (comment)

If you want to release a new extension version, please update the version in setup.py as well

@qwuae1
Copy link
Contributor Author

qwuae1 commented Apr 1, 2024

Please take a look at this comment: #7436 (comment)

If you want to release a new extension version, please update the version in setup.py as well

thx, resolve it

@zhoxing-ms zhoxing-ms merged commit f7c0a8e into Azure:main Apr 1, 2024
14 of 15 checks passed
@azclibot
Copy link
Collaborator

azclibot commented Apr 1, 2024

[Release] Update index.json for extension [ vm-repair ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=145001&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants