Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove nodeSelector support for egress gateway for az aks mesh command. #7438

Merged
merged 20 commits into from
Apr 8, 2024
Merged

Remove nodeSelector support for egress gateway for az aks mesh command. #7438

merged 20 commits into from
Apr 8, 2024

Conversation

deveshdama
Copy link
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az aks mesh enable-egress-gateway -g myRG -n myCluster

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Mar 29, 2024

❌Azure CLI Extensions Breaking Change Test
❌aks-preview
rule cmd_name rule_message suggest_message
1007 - ParaRemove aks mesh enable-egress-gateway cmd aks mesh enable-egress-gateway removed parameter egx_gtw_nodeselector please add back parameter egx_gtw_nodeselector for cmd aks mesh enable-egress-gateway

Copy link

Hi @deveshdama,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

@yonzhan
Copy link
Collaborator

yonzhan commented Mar 29, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link

github-actions bot commented Apr 1, 2024

⚠️ Suggestions

Module: aks-preview

  • Update version to 2.0.0b9 in setup.py
  • Set azext.isPreview to true in azext_aks-preview/azext_metadata.json if not exists

Notes

  • Stable/preview tag is inherited from last release. If needed, please add stable/preview label to modify it.
  • Major/minor/patch/pre increment of version number is calculated by pull request code changes automatically. If needed, please add major/minor/patch/pre label to adjust it.
  • For more info about extension versioning, please refer to Extension version schema

Copy link
Member

@FumingZhang FumingZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Queued live test to validate the change.

  • test_aks_azure_service_mesh_enable_disable
  • test_aks_azure_service_mesh_with_ingress_gateway
  • test_aks_azure_service_mesh_with_egress_gateway
  • test_aks_azure_service_mesh_with_pluginca
  • test_aks_azure_service_mesh_get_revisions
  • test_aks_azure_service_mesh_get_upgrades

BTW, case test_aks_azure_service_mesh_get_revisions is still filtered out by default (src/aks-preview/azcli_aks_live_test/configs/ext_matrix_default.json), do you think it's the time to add it back?

        "service mesh, missing feature registration for new resource type": [
            "test_aks_azure_service_mesh_get_revisions"
        ],

src/aks-preview/HISTORY.rst Show resolved Hide resolved
src/aks-preview/HISTORY.rst Outdated Show resolved Hide resolved
src/aks-preview/setup.py Outdated Show resolved Hide resolved
@deveshdama
Copy link
Contributor Author

Queued live test to validate the change.

  • test_aks_azure_service_mesh_enable_disable
  • test_aks_azure_service_mesh_with_ingress_gateway
  • test_aks_azure_service_mesh_with_egress_gateway
  • test_aks_azure_service_mesh_with_pluginca
  • test_aks_azure_service_mesh_get_revisions
  • test_aks_azure_service_mesh_get_upgrades

BTW, case test_aks_azure_service_mesh_get_revisions is still filtered out by default (src/aks-preview/azcli_aks_live_test/configs/ext_matrix_default.json), do you think it's the time to add it back?

        "service mesh, missing feature registration for new resource type": [
            "test_aks_azure_service_mesh_get_revisions"
        ],

@deveshdama deveshdama closed this Apr 2, 2024
@FumingZhang FumingZhang reopened this Apr 2, 2024
@yanzhudd yanzhudd merged commit fb4789b into Azure:main Apr 8, 2024
15 checks passed
@azclibot
Copy link
Collaborator

azclibot commented Apr 8, 2024

[Release] Update index.json for extension [ aks-preview ] : https://dev.azure.com/azclitools/release/_build/results?buildId=146395&view=results

blackchoey pushed a commit to blackchoey/azure-cli-extensions that referenced this pull request Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants