Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{AKS} Bump the minimum required cli core version to 2.56.0 #7442

Merged
merged 3 commits into from
Apr 2, 2024

Conversation

FumingZhang
Copy link
Member

@FumingZhang FumingZhang commented Apr 1, 2024


This checklist is used to make sure that common guidelines for a pull request are followed.

In the new SDK used in aks-preview since 2.0.0b7, it starts using SensitiveHeaderCleanupPolicy provided by azure.core. aks-preview does not separately declare its dependency on the version of azure.core, but inherits from the declaration in azure-cli. In azure-cli PR #27783, the dependency on azure.core is bumped to 1.28.0 (in which SensitiveHeaderCleanupPolicy was introduced). Changes in #27783 were released in 2.56.0. So changing the minimum required cli core version to 2.56.0.

For users who encounter similar problems, the recommended workaround is to upgrade azure-cli to version 2.56.0 and later.

Sample error

File \"/opt/az/lib/python3.10/site-packages/knack/cli.py\", line 233, in invoke
    cmd_result = self.invocation.execute(args)
  File \"/opt/az/lib/python3.10/site-packages/azure/cli/core/commands/__init__.py\", line 663, in execute
    raise ex
  File \"/opt/az/lib/python3.10/site-packages/azure/cli/core/commands/__init__.py\", line 726, in _run_jobs_serially
    results.append(self._run_job(expanded_arg, cmd_copy))
  File \"/opt/az/lib/python3.10/site-packages/azure/cli/core/commands/__init__.py\", line 697, in _run_job
    result = cmd_copy(params)
  File \"/opt/az/lib/python3.10/site-packages/azure/cli/core/commands/__init__.py\", line 333, in __call__
    return self.handler(*args, **kwargs)
  File \"/opt/az/lib/python3.10/site-packages/azure/cli/core/commands/command_operation.py\", line 112, in handler
    client = self.client_factory(self.cli_ctx, command_args) if self.client_factory else None
  File \"/root/.azure/cliextensions/aks-preview/azext_aks_preview/_client_factory.py\", line 31, in cf_managed_clusters
    return get_container_service_client(cli_ctx).managed_clusters
  File \"/root/.azure/cliextensions/aks-preview/azext_aks_preview/_client_factory.py\", line 23, in get_container_service_client
    return get_mgmt_service_client(cli_ctx, CUSTOM_MGMT_AKS_PREVIEW, subscription_id=subscription_id)
  File \"/opt/az/lib/python3.10/site-packages/azure/cli/core/commands/client_factory.py\", line 83, in get_mgmt_service_client
    client, _ = _get_mgmt_service_client(cli_ctx, client_type, subscription_id=subscription_id,
  File \"/opt/az/lib/python3.10/site-packages/azure/cli/core/commands/client_factory.py\", line 251, in _get_mgmt_service_client
    client = client_type(credential, subscription_id, **client_kwargs)
  File \"/root/.azure/cliextensions/aks-preview/azext_aks_preview/vendored_sdks/azure_mgmt_preview_aks/_container_service_client.py\", line 98, in __init__
    policies.SensitiveHeaderCleanupPolicy(**kwargs) if self._config.redirect_policy else None,
AttributeError: module 'azure.core.pipeline.policies' has no attribute 'SensitiveHeaderCleanupPolicy'
To check existing issues, please visit: https://github.com/Azure/azure-cli/issues"

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Apr 1, 2024

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

Copy link

Hi @FumingZhang,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

Copy link

Hi @FumingZhang,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

@yonzhan
Copy link
Collaborator

yonzhan commented Apr 1, 2024

AKS

@FumingZhang FumingZhang force-pushed the fuming/aks-bump-dependency-0401 branch from deb763a to 039b020 Compare April 2, 2024 02:56
@yanzhudd yanzhudd merged commit 593bc7f into Azure:main Apr 2, 2024
15 checks passed
@azclibot
Copy link
Collaborator

azclibot commented Apr 2, 2024

[Release] Update index.json for extension [ aks-preview ] : https://dev.azure.com/azclitools/release/_build/results?buildId=145347&view=results

@FumingZhang FumingZhang deleted the fuming/aks-bump-dependency-0401 branch May 11, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AKS Auto-Assign Auto assign by bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants