Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{CI} Cancel serial release #7443

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

wangzelin007
Copy link
Member

@wangzelin007 wangzelin007 commented Apr 1, 2024


There can be at most one running and one pending job in a concurrency group at any time.
image
https://github.com/orgs/community/discussions/41518
https://github.com/orgs/community/discussions/12835
If extension A and extension B are released at the same time, B's pengding release workflow will be canceled because of extension A's automatically update index.json commit.
image

So we still keep concurrent release for CLI extensions.
But after each release, we will ensure that pull the latest index.json from main branch and overwrite the index.json in blob.(The last task in OneBranch extension release pipeline)

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Apr 1, 2024

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

Copy link

Hi @wangzelin007,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

Copy link

Hi @wangzelin007,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

@yonzhan
Copy link
Collaborator

yonzhan commented Apr 1, 2024

CI

@wangzelin007
Copy link
Member Author

wangzelin007 commented Apr 1, 2024

@bebound
Since it is too late and there are issues with the previous code, I will merge this PR first.
Please help review this PR when you are available.
You can check the code of pull the latest index.json from main branch and overwrite the index.json in blob.

@wangzelin007 wangzelin007 merged commit 194515d into Azure:main Apr 1, 2024
17 checks passed
Copy link
Contributor

@bebound bebound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Assign Auto assign by bot CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants