Add log streaming for container app jobs #7454

lihaMSFT · 2024-04-03T22:15:52Z

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az containerapp job logs show
az containerapp job replica

General Guidelines

Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
My extension version conforms to the Extension version schema

For new extensions:

My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

azure-client-tools-bot-prd · 2024-04-03T22:15:55Z

⚠️Azure CLI Extensions Breaking Change Test

⚠️containerapp

rule cmd_name rule_message suggest_message

⚠️ 1011 - SubgroupAdd containerapp job logs sub group containerapp job logs added

⚠️ 1011 - SubgroupAdd containerapp job replica sub group containerapp job replica added

azure-client-tools-bot-prd · 2024-04-03T22:15:58Z

Hi @lihaMSFT,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

yonzhan · 2024-04-03T22:16:04Z

Thank you for your contribution! We will review the pull request and get back to you soon.

MoazzemHossain-bot

Thanks

MoazzemHossain-bot

Thanks for supporting

Moazzem-Hossain-pixel

Thanks

src/containerapp/azext_containerapp/_clients.py

Greedygre · 2024-05-29T02:57:12Z

src/containerapp/HISTORY.rst

+* 'az containerapp job logs show': Support log streaming for job execution
+* 'az containerapp job replica list': Support list replicas of a job execution


Please move these to upcoming.

Greedygre · 2024-05-29T03:27:55Z

About CI failed:
There are 5 tests failed, I have help to fix 4 of them with PR due to az containerapp job update polling logic fix in azure-cli.
The rest one test_containerappjob_logstream, please rerun it with --live, and update the recording file.

FAILED src/containerapp/azext_containerapp/tests/latest/test_containerappjob_crud.py::ContainerAppJobsCRUDOperationsTest::test_containerapp_manualjob_crudoperations_e2e
FAILED src/containerapp/azext_containerapp/tests/latest/test_containerappjob_event_triggered_crud.py::ContainerAppJobsCRUDOperationsTest::test_containerapp_eventjob_crudoperations_e2e
FAILED src/containerapp/azext_containerapp/tests/latest/test_containerappjob_executions.py::ContainerAppJobsExecutionsTest::test_containerappjob_logstream
FAILED src/containerapp/azext_containerapp/tests/latest/test_containerappjob_with_yaml.py::ContainerAppJobsExecutionsLocationNotInStageTest::test_containerappjob_create_with_yaml
FAILED src/containerapp/azext_containerapp/tests/latest/test_containerappjob_with_yaml.py::ContainerAppJobsExecutionsLocationNotInStageTest::test_containerappjob_eventtriggered_create_with_yaml

lihaMSFT · 2024-05-29T20:57:31Z

@Greedygre the tests are passing now.

Greedygre · 2024-05-31T05:48:38Z

@Greedygre the tests are passing now.

Please resolve the conflict. Or you can assign the right to my account Greedygre, I can help to resolve small conflict in history.rst

Greedygre

Please resolve the conflict conflict in src/containerapp/HISTORY.rst

yonzhan · 2024-05-31T06:17:59Z

Please fix conflicting files.

Greedygre · 2024-06-03T08:36:25Z

Hi @lihaMSFT

I recommend you only update your test's yaml file test_containerappjob_logstream after update azure-cli dev branch to latest code then rerun it with --live.
About other 4 tests you can use command git checkout main src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_eventjob_crudoperations_e2e.yaml to checkout to the main branch.

Please assign permission for your repo to my account Greedygre, so that I can handle small conflict.

Greedygre · 2024-06-04T00:22:02Z

src/containerapp/azext_containerapp/commands.py

+    with self.command_group('containerapp job logs') as g:
+        g.custom_show_command('show', 'stream_job_logs')
+
+    with self.command_group('containerapp job replica') as g:


Please add is_preview=True as they are preview feature's commands.

src/containerapp/azext_containerapp/commands.py

Greedygre · 2024-06-04T00:25:41Z

src/containerapp/azext_containerapp/commands.py

@@ -205,6 +205,12 @@ def load_command_table(self, args):
        g.custom_show_command('show', 'show_eureka_server_for_spring')
        g.custom_command('delete', 'delete_eureka_server_for_spring', confirmation=True, supports_no_wait=True)

+    with self.command_group('containerapp job logs') as g:


Same as this, add is_preview=True.

src/containerapp/azext_containerapp/commands.py

lihaMSFT added 4 commits April 3, 2024 21:56

init

4f0efc1

Merge branch 'main' of https://github.com/Azure/azure-cli-extensions

dc79cc4

reorder

88a111a

revert

66dfe0a

azure-client-tools-bot-prd bot added this to the April 2024 (2024-04-30) milestone Apr 3, 2024

microsoft-github-policy-service bot requested review from yonzhan and wangzelin007 April 3, 2024 22:16

microsoft-github-policy-service bot requested review from yanzhudd, zhoxing-ms, jsntcy, ruslany, sanchitmehta, ebencarek, JennyLawrance, howang-ms, vinisoto, chinadragon0515, vturecek, torosent, pagariyaalok, Juliehzl, jijohn14 and Greedygre April 3, 2024 22:16

microsoft-github-policy-service bot added customer-reported Issues that are reported by GitHub users external to the Azure organization. Auto-Assign Auto assign by bot labels Apr 3, 2024

microsoft-github-policy-service bot assigned zhoxing-ms Apr 3, 2024

microsoft-github-policy-service bot added the ContainerApp label Apr 3, 2024

MoazzemHossain-bot approved these changes May 14, 2024

View reviewed changes

Moazzem-Hossain-pixel approved these changes May 14, 2024

View reviewed changes

lihaMSFT added 3 commits May 28, 2024 22:13

Merge branch 'main' of https://github.com/Azure/azure-cli-extensions

57f23d4

Override api version

9c36ae6

Fix test

68ec09f

Greedygre reviewed May 29, 2024

View reviewed changes

src/containerapp/azext_containerapp/_clients.py Show resolved Hide resolved

Greedygre reviewed May 29, 2024

View reviewed changes

Fix tests

7a06f89

lihaMSFT added 3 commits May 29, 2024 20:58

Changed release history to upcoming

2817e62

Merge branch 'main' of https://github.com/Azure/azure-cli-extensions

c778593

Fix build

32436dd

Greedygre approved these changes May 31, 2024

View reviewed changes

Merge branch 'main' of https://github.com/Azure/azure-cli-extensions

f979ac8

Fix tests

61d64fb

Greedygre reviewed Jun 4, 2024

View reviewed changes

src/containerapp/azext_containerapp/commands.py Outdated Show resolved Hide resolved

Greedygre reviewed Jun 4, 2024

View reviewed changes

Update src/containerapp/azext_containerapp/commands.py

74d366c

Greedygre reviewed Jun 4, 2024

View reviewed changes

src/containerapp/azext_containerapp/commands.py Outdated Show resolved Hide resolved

Update src/containerapp/azext_containerapp/commands.py

bc96d7d

Greedygre approved these changes Jun 4, 2024

View reviewed changes

yanzhudd approved these changes Jun 4, 2024

View reviewed changes

yanzhudd merged commit dff3621 into Azure:main Jun 4, 2024
15 of 16 checks passed

liorstauber pushed a commit to liorstauber/azure-cli-extensions that referenced this pull request Jul 14, 2024

Add log streaming for container app jobs (Azure#7454)

6b39e5b

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add log streaming for container app jobs #7454

Add log streaming for container app jobs #7454

lihaMSFT commented Apr 3, 2024 •

edited

Loading

azure-client-tools-bot-prd bot commented Apr 3, 2024 •

edited

Loading

azure-client-tools-bot-prd bot commented Apr 3, 2024

yonzhan commented Apr 3, 2024

MoazzemHossain-bot left a comment

MoazzemHossain-bot left a comment

Moazzem-Hossain-pixel left a comment

Greedygre May 29, 2024

Greedygre commented May 29, 2024 •

edited

Loading

lihaMSFT commented May 29, 2024

Greedygre commented May 31, 2024 •

edited

Loading

Greedygre left a comment •

edited

Loading

yonzhan commented May 31, 2024

Greedygre commented Jun 3, 2024

Greedygre Jun 4, 2024

Greedygre Jun 4, 2024

		* 'az containerapp job logs show': Support log streaming for job execution
		* 'az containerapp job replica list': Support list replicas of a job execution

Add log streaming for container app jobs #7454

Add log streaming for container app jobs #7454

Conversation

lihaMSFT commented Apr 3, 2024 • edited Loading

Related command

General Guidelines

About Extension Publish

azure-client-tools-bot-prd bot commented Apr 3, 2024 • edited Loading

azure-client-tools-bot-prd bot commented Apr 3, 2024

yonzhan commented Apr 3, 2024

MoazzemHossain-bot left a comment

Choose a reason for hiding this comment

MoazzemHossain-bot left a comment

Choose a reason for hiding this comment

Moazzem-Hossain-pixel left a comment

Choose a reason for hiding this comment

Greedygre May 29, 2024

Choose a reason for hiding this comment

Greedygre commented May 29, 2024 • edited Loading

lihaMSFT commented May 29, 2024

Greedygre commented May 31, 2024 • edited Loading

Greedygre left a comment • edited Loading

Choose a reason for hiding this comment

yonzhan commented May 31, 2024

Greedygre commented Jun 3, 2024

Greedygre Jun 4, 2024

Choose a reason for hiding this comment

Greedygre Jun 4, 2024

Choose a reason for hiding this comment

lihaMSFT commented Apr 3, 2024 •

edited

Loading

azure-client-tools-bot-prd bot commented Apr 3, 2024 •

edited

Loading

Greedygre commented May 29, 2024 •

edited

Loading

Greedygre commented May 31, 2024 •

edited

Loading

Greedygre left a comment •

edited

Loading