Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ConnectedK8s] Add support for multiple proxy instances running on the same machine using different ports #7455

Merged
merged 3 commits into from
Apr 9, 2024

Conversation

RyanBDB
Copy link
Contributor

@RyanBDB RyanBDB commented Apr 4, 2024

This PR addresses #6366

For our use case, it would be very helpful for the connectedk8s proxy to support multiple instances running on the same machine. This enables interactions/ control over multiple Arc connected Kubernetes clusters from the same machine by simply switching your kube context.

I've tested the change locally and been able to run multiple proxies on different ports and use kubectl to target multiple clusters by switching kube context.


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az connectedk8s proxy

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Apr 4, 2024

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

Copy link

Hi @RyanBDB,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Apr 4, 2024

ConnectedK8s

@RyanBDB
Copy link
Contributor Author

RyanBDB commented Apr 4, 2024

Note, azdev style is failing, but the flagged issues are not par of the code changes in this PR.

Copy link

github-actions bot commented Apr 8, 2024

⚠️ Suggestions

Module: connectedk8s

  • Update version to 1.6.8 in setup.py

Notes

  • Stable/preview tag is inherited from last release. If needed, please add stable/preview label to modify it.
  • Major/minor/patch/pre increment of version number is calculated by pull request code changes automatically. If needed, please add major/minor/patch/pre label to adjust it.
  • For more info about extension versioning, please refer to Extension version schema

@zhoxing-ms
Copy link
Contributor

@darrendejaeger Could you please help review it again?

@zhoxing-ms zhoxing-ms merged commit 7087f56 into Azure:main Apr 9, 2024
16 of 17 checks passed
@azclibot
Copy link
Collaborator

azclibot commented Apr 9, 2024

[Release] Update index.json for extension [ connectedk8s ] : https://dev.azure.com/azclitools/release/_build/results?buildId=146822&view=results

blackchoey pushed a commit to blackchoey/azure-cli-extensions that referenced this pull request Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants