Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NetAppFiles] Update extension to 2023-07-01-preview models #7485

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

audunn
Copy link
Member

@audunn audunn commented Apr 9, 2024


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Apr 9, 2024

❌Azure CLI Extensions Breaking Change Test
❌netappfiles-preview
rule cmd_name rule_message suggest_message
1007 - ParaRemove netappfiles account backup-vault backup update cmd netappfiles account backup-vault backup update removed parameter use_existing_snapshot please add back parameter use_existing_snapshot for cmd netappfiles account backup-vault backup update
1007 - ParaRemove netappfiles volume create cmd netappfiles volume create removed parameter replication_id please add back parameter replication_id for cmd netappfiles volume create
1010 - ParaPropUpdate netappfiles volume create cmd netappfiles volume create update parameter smb_continuously_available: updated property options from ['--smb-ca', '--smb-continuously-available'] to ['--smb-continuously-available', '--smb-continuously-avl'] please change property options from ['--smb-continuously-available', '--smb-continuously-avl'] to ['--smb-ca', '--smb-continuously-available'] for parameter smb_continuously_available of cmd netappfiles volume create
1007 - ParaRemove netappfiles volume update cmd netappfiles volume update removed parameter remote_volume_resource_id please add back parameter remote_volume_resource_id for cmd netappfiles volume update
1007 - ParaRemove netappfiles volume update cmd netappfiles volume update removed parameter replication_id please add back parameter replication_id for cmd netappfiles volume update
1010 - ParaPropUpdate netappfiles volume update cmd netappfiles volume update update parameter smb_continuously_available: updated property options from ['--smb-ca', '--smb-continuously-available'] to ['--smb-continuously-available', '--smb-continuously-avl'] please change property options from ['--smb-continuously-available', '--smb-continuously-avl'] to ['--smb-ca', '--smb-continuously-available'] for parameter smb_continuously_available of cmd netappfiles volume update
⚠️ 1006 - ParaAdd netappfiles volume create cmd netappfiles volume create added parameter cool_access_retrieval_policy
⚠️ 1006 - ParaAdd netappfiles volume create cmd netappfiles volume create added parameter remote_path
⚠️ 1010 - ParaPropUpdate netappfiles volume create cmd netappfiles volume create update parameter network_features: updated property choices from ['Basic', 'Standard'] to ['Basic', 'Basic_Standard', 'Standard', 'Standard_Basic']
⚠️ 1010 - ParaPropUpdate netappfiles volume create cmd netappfiles volume create update parameter rules: updated property name from rules to export_policy_rules
⚠️ 1010 - ParaPropUpdate netappfiles volume create cmd netappfiles volume create update parameter rules: updated property options from ['--rules'] to ['--export-policy-rules', '--rules']
⚠️ 1008 - ParaPropAdd netappfiles volume create cmd netappfiles volume create update parameter subnet_id: added property aaz_default=default
⚠️ 1008 - ParaPropAdd netappfiles volume create cmd netappfiles volume create update parameter subnet_id: added property default=default
⚠️ 1009 - ParaPropRemove netappfiles volume create cmd netappfiles volume create update parameter subnet_id: removed property required=True
⚠️ 1010 - ParaPropUpdate netappfiles volume latest-backup-status current show cmd netappfiles volume latest-backup-status current show update parameter volume_name: updated property options from ['--volume-name'] to ['--volume-name', '-v']
⚠️ 1011 - SubgroupAdd netappfiles volume latest-restore-status sub group netappfiles volume latest-restore-status added
⚠️ 1006 - ParaAdd netappfiles volume update cmd netappfiles volume update added parameter cool_access_retrieval_policy
⚠️ 1010 - ParaPropUpdate netappfiles volume update cmd netappfiles volume update update parameter network_features: updated property choices from ['Basic', 'Standard'] to ['Basic', 'Basic_Standard', 'Standard', 'Standard_Basic']
⚠️ 1010 - ParaPropUpdate netappfiles volume update cmd netappfiles volume update update parameter rules: updated property name from rules to export_policy_rules
⚠️ 1010 - ParaPropUpdate netappfiles volume update cmd netappfiles volume update update parameter rules: updated property options from ['--rules'] to ['--export-policy-rules', '--rules']

Copy link

Hi @audunn,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Apr 9, 2024

NetAppFiles

Copy link

github-actions bot commented Apr 10, 2024

⚠️ Release Suggestions

Module: netappfiles-preview

  • Update version to 1.0.0b2 in setup.py

Notes

  • Stable/preview tag is inherited from last release. If needed, please add stable/preview label to modify it.
  • Major/minor/patch/pre increment of version number is calculated by pull request code changes automatically. If needed, please add major/minor/patch/pre label to adjust it.
  • For more info about extension versioning, please refer to Extension version schema

@AllyW
Copy link
Member

AllyW commented Apr 15, 2024

@audunn please also write the description of changes which can be perceived by customers into HISTORY.rst as well.

@kairu-ms
Copy link
Contributor

It seems breaking changes are included. Please confirm
image

@@ -2,6 +2,11 @@

Release History
===============
0.4.3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the version number here should be consist with the version in setup.py

@AllyW AllyW added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-cal-version release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants