[quantum] Assign "Storage account contributor" role to workspace for linked StorageAccount #7497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️Azure CLI Extensions Breaking Change Test
|
|
Hi @ashwinmayya, |
|
quantum |
microsoft-github-policy-service
bot
requested review from
yonzhan and
wangzelin007
|
|
Do we have any tests to cover this change? |
Yes these changes are covered by existing tests that create the workspace and submit jobs. There should be no change in functionality for existing users, hence no new tests. |
kairu-ms
approved these changes
Apr 16, 2024
|
[Release] Update index.json for extension [ quantum ] : https://dev.azure.com/azclitools/release/_build/results?buildId=149062&view=results |
blackchoey
pushed a commit
to blackchoey/azure-cli-extensions
that referenced
this pull request
Apr 29, 2024
…linked StorageAccount (Azure#7497) * Assign storage account contributor to workspace * Update version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we assigned a contributor role to the storage account for the workspace. This PR changes it to the "storage account contributor" role. This is done in order to be compatible with the new "Quantum Workspace Owner" built-in role that allows constrained role assignment of storage account contributor.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.