Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AKS] support --yes for az aks mesh upgrade commands. #7508

Merged
merged 20 commits into from
Apr 24, 2024
Merged

[AKS] support --yes for az aks mesh upgrade commands. #7508

merged 20 commits into from
Apr 24, 2024

Conversation

deveshdama
Copy link
Contributor

@deveshdama deveshdama commented Apr 16, 2024


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az aks mesh upgrade rollback -g myResourceGroup -n myCluster --revision asm-1-20
az aks mesh upgrade complete -g myResourceGroup -n myCluster

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Apr 16, 2024

⚠️Azure CLI Extensions Breaking Change Test
⚠️aks-preview
rule cmd_name rule_message suggest_message
⚠️ 1006 - ParaAdd aks mesh upgrade complete cmd aks mesh upgrade complete added parameter yes
⚠️ 1006 - ParaAdd aks mesh upgrade rollback cmd aks mesh upgrade rollback added parameter yes

Copy link

Hi @deveshdama,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Apr 16, 2024

AKS

Copy link

github-actions bot commented Apr 16, 2024

⚠️ Release Suggestions

Module: aks-preview

  • Update version to 3.0.0b7 in setup.py

Notes

  • Stable/preview tag is inherited from last release. If needed, please add stable/preview label to modify it.
  • Major/minor/patch/pre increment of version number is calculated by pull request code changes automatically. If needed, please add major/minor/patch/pre label to adjust it.
  • For more info about extension versioning, please refer to Extension version schema

@deveshdama deveshdama changed the title [AKS] support --yes for az aks mesh upgrade rollback command [AKS] support --yes for az aks mesh upgrade commands. Apr 16, 2024
Copy link
Member

@FumingZhang FumingZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

But I find there's no scenario test for command aks mesh upgrade rollback/complete, a passed live test could help ensure that everything is working properly.

Copy link
Member

@FumingZhang FumingZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Live test passed

  • test_aks_azure_service_mesh_canary_upgrade

src/aks-preview/azext_aks_preview/_params.py Outdated Show resolved Hide resolved
src/aks-preview/azext_aks_preview/_params.py Outdated Show resolved Hide resolved
src/aks-preview/setup.py Outdated Show resolved Hide resolved
@FumingZhang
Copy link
Member

CI failure is not related to the change in this PR, would be fixed in #7548.

>               self.agentpool.windows_profile.disable_windows_outbound_nat is not None
            ):
E           AttributeError: 'AgentPoolWindowsProfile' object has no attribute 'disable_windows_outbound_nat'

@yanzhudd
Copy link
Contributor

/azp run

Copy link

Pull request contains merge conflicts.

@yanzhudd
Copy link
Contributor

Please resolve the code conflict.

@deveshdama
Copy link
Contributor Author

resolved.

@yanzhudd yanzhudd merged commit 5498d0e into Azure:main Apr 24, 2024
15 checks passed
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ aks-preview ] : https://dev.azure.com/azclitools/release/_build/results?buildId=152072&view=results

blackchoey pushed a commit to blackchoey/azure-cli-extensions that referenced this pull request Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AKS Auto-Assign Auto assign by bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants