-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AKS] support --yes
for az aks mesh upgrade
commands.
#7508
Conversation
|
rule | cmd_name | rule_message | suggest_message |
---|---|---|---|
aks mesh upgrade complete | cmd aks mesh upgrade complete added parameter yes |
||
aks mesh upgrade rollback | cmd aks mesh upgrade rollback added parameter yes |
Hi @deveshdama, |
AKS |
|
--yes
for az aks mesh upgrade rollback
command--yes
for az aks mesh upgrade
commands.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
But I find there's no scenario test for command aks mesh upgrade rollback/complete
, a passed live test could help ensure that everything is working properly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Live test passed
- test_aks_azure_service_mesh_canary_upgrade
Co-authored-by: Yan Zhu <[email protected]>
CI failure is not related to the change in this PR, would be fixed in #7548.
|
/azp run |
Pull request contains merge conflicts. |
Please resolve the code conflict. |
resolved. |
[Release] Update index.json for extension [ aks-preview ] : https://dev.azure.com/azclitools/release/_build/results?buildId=152072&view=results |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az aks mesh upgrade rollback -g myResourceGroup -n myCluster --revision asm-1-20
az aks mesh upgrade complete -g myResourceGroup -n myCluster
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally? (pip install wheel==0.30.0
required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.json
automatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json
.