Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AKS] Add --enable-azure-monitor-app-monitoring and --disable-azure-monitor-app-monitoring to aks-preview #7514

Merged
merged 16 commits into from
Apr 24, 2024

Conversation

jatakiajanvi12
Copy link
Contributor

@jatakiajanvi12 jatakiajanvi12 commented Apr 16, 2024


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

aks update --resource-group={resource_group} --name={name} ---enable-azure-monitor-app-monitoring
aks update --resource-group={resource_group} --name={name} ---disable-azure-monitor-app-monitoring

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Apr 16, 2024

⚠️Azure CLI Extensions Breaking Change Test
⚠️aks-preview
rule cmd_name rule_message suggest_message
⚠️ 1006 - ParaAdd aks create cmd aks create added parameter enable_azure_monitor_app_monitoring
⚠️ 1006 - ParaAdd aks update cmd aks update added parameter disable_azure_monitor_app_monitoring
⚠️ 1006 - ParaAdd aks update cmd aks update added parameter enable_azure_monitor_app_monitoring

@yonzhan
Copy link
Collaborator

yonzhan commented Apr 16, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link

github-actions bot commented Apr 16, 2024

⚠️ Release Suggestions

Module: aks-preview

  • Update version to 3.0.0b6 in setup.py

Notes

  • Stable/preview tag is inherited from last release. If needed, please add stable/preview label to modify it.
  • Major/minor/patch/pre increment of version number is calculated by pull request code changes automatically. If needed, please add major/minor/patch/pre label to adjust it.
  • For more info about extension versioning, please refer to Extension version schema

@jatakiajanvi12 jatakiajanvi12 changed the title Add --enable-azure-monitor-app-monitoring and --disable-azure-monitor-app-monitoring to aks-preview [AKS] Add --enable-azure-monitor-app-monitoring and --disable-azure-monitor-app-monitoring to aks-preview Apr 16, 2024
Copy link
Member

@FumingZhang FumingZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Queued live test to validate the change
Requeued live test to run in staging env.

  • test_aks_create_with_azuremonitorappmonitoring
  • test_aks_update_with_azuremonitorappmonitoring

@yanzhudd yanzhudd merged commit c9e1942 into Azure:main Apr 24, 2024
15 checks passed
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ aks-preview ] : https://dev.azure.com/azclitools/release/_build/results?buildId=151977&view=results

blackchoey pushed a commit to blackchoey/azure-cli-extensions that referenced this pull request Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AKS Auto-Assign Auto assign by bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants