Address bastion native client Issues and add proper error messages #7555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️Azure CLI Extensions Breaking Change Test
|
azure-client-tools-bot-prd
bot
added this to the May 2024 (2024-05-21)❗ Breaking change release ❗ milestone
|
Hi @Tejaswikandula, |
|
Hi @Tejaswikandula, |
microsoft-github-policy-service
bot
added
the
customer-reported
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
For more info about extension versioning, please refer to Extension version schema |
Tejaswikandula
changed the title
|
please record the test cases based on the latest azure-cli |
abhi7860
reviewed
May 16, 2024
abhi7860
approved these changes
May 16, 2024
|
Please fix CI issues |
github-actions
bot
added
the
release-version-block
github-actions
bot
removed
the
release-version-block
necusjz
approved these changes
Jun 12, 2024
|
[Release] Update index.json for extension [ bastion ] : https://dev.azure.com/azclitools/release/_build/results?buildId=164689&view=results |
liorstauber
pushed a commit
to liorstauber/azure-cli-extensions
that referenced
this pull request
Jul 14, 2024
…zure#7555) * Add proper error message for --target-ip-address-flag issue * Fix indentation * Add recordings file * update ver * update recordings file * Changes to support premium SKU for native client * Change method name * upload latest recordsings * Add changes to history.txt and update version * Upgrade cli version to 1.0.0 removing preview flag * force push to rerun build * force push to rerun build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the following bastion native client Issues
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.