Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Container app] az containerapp sessionpool: Support sessionpool command. #7559

Merged
merged 20 commits into from
May 14, 2024

Conversation

yalixiang
Copy link
Contributor

@yalixiang yalixiang commented Apr 29, 2024


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Apr 29, 2024

⚠️Azure CLI Extensions Breaking Change Test
⚠️containerapp
rule cmd_name rule_message suggest_message
⚠️ 1011 - SubgroupAdd containerapp sessionpool sub group containerapp sessionpool added

Copy link

Hi @yalixiang,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

Copy link

Hi @yalixiang,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Apr 29, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

@microsoft-github-policy-service microsoft-github-policy-service bot added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Apr 29, 2024
Copy link

github-actions bot commented Apr 29, 2024

⚠️ Release Suggestions

Module: containerapp

  • Update VERSION to 1.0.0b1 in src/containerapp/setup.py

Notes

  • Stable/preview tag is inherited from last release. If needed, please add stable/preview label to modify it.
  • Major/minor/patch/pre increment of version number is calculated by pull request code changes automatically. If needed, please add major/minor/patch/pre label to adjust it.
  • For more info about extension versioning, please refer to Extension version schema

@yalixiang yalixiang marked this pull request as ready for review April 29, 2024 12:47
@yonzhan
Copy link
Collaborator

yonzhan commented Apr 29, 2024

Please fix CI issues

@yalixiang yalixiang force-pushed the user/yalixiang/sessionpool branch from ea9e829 to 1ab7c03 Compare May 6, 2024 03:50
@Greedygre
Copy link
Contributor

Recommend title:
[Container app] az containerapp sessionpool: Support sessionpool command.

And please update history.rst

@yalixiang yalixiang changed the title Add sessionpool CRUD [Container app] az containerapp sessionpool: Support sessionpool command. May 14, 2024
@yanzhudd yanzhudd merged commit e1d6a22 into Azure:main May 14, 2024
14 of 15 checks passed
Copy link

@Moazzem-Hossain-pixel Moazzem-Hossain-pixel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never support

Copy link

@Moazzem-Hossain-pixel Moazzem-Hossain-pixel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

harryli0108 pushed a commit to harryli0108/azure-cli-extensions that referenced this pull request May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customer-reported Issues that are reported by GitHub users external to the Azure organization.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants