feat(acns): add advanced network observability enable/disable for az … #7562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snguyen64
requested review from
andyliuliming,
FumingZhang and
kairu-ms
as code owners
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| aks create | cmd aks create added parameter enable_advanced_network_observability |
||
| aks update | cmd aks update added parameter disable_advanced_network_observability |
||
| aks update | cmd aks update added parameter enable_advanced_network_observability |
azure-client-tools-bot-prd
bot
added this to the May 2024 (2024-05-21)❗ Breaking change release ❗ milestone
|
Hi @snguyen64, |
|
Hi @snguyen64, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
microsoft-github-policy-service
bot
requested review from
zhoxing-ms,
yanzhudd,
yonzhan,
jsntcy and
necusjz
|
FumingZhang
reviewed
Apr 30, 2024
There was a problem hiding this comment.
lgtm
Queued live test to validate the change, test passed!
- test_aks_create_with_enable_advanced_network_observability
- test_aks_update_enable_advanced_network_observability
Please resolve merge conflict.
…aks create and update commands
snguyen64
force-pushed
the
retina/adv_net_obs
branch
from
100b383
to
71cd8c8
Compare
FumingZhang
approved these changes
May 6, 2024
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Moazzem-Hossain-pixel
approved these changes
May 6, 2024
zhoxing-ms
approved these changes
May 6, 2024
Greedygre
pushed a commit
to Greedygre/azure-cli-extensions
that referenced
this pull request
May 7, 2024
Azure#7562) * feat(acns): add advanced network observability enable/disable for az aks create and update commands * Update HISTORY.rst --------- Co-authored-by: FumingZhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates commands for enabling/disabling Advanced Network Observability features during cluster creation and update for aks-preview.
az aks create --enable-advanced-network-observabilityaz aks update --enable-advanced-network-observabilityaz aks update --disable-advanced-network-observabilityThis checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.