Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Service Connector] az webapp connection create: add parameter to be compatible with CLI core #7573

Merged
merged 5 commits into from
May 7, 2024

Conversation

xfz11
Copy link
Member

@xfz11 xfz11 commented May 6, 2024


This checklist is used to make sure that common guidelines for a pull request are followed.
Fix Azure/azure-cli#28865

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented May 6, 2024

❌Azure CLI Extensions Breaking Change Test
❌serviceconnector-passwordless
rule cmd_name rule_message suggest_message
1007 - ParaRemove aks connection create mysql-flexible cmd aks connection create mysql-flexible removed parameter key_vault_id please add back parameter key_vault_id for cmd aks connection create mysql-flexible
1007 - ParaRemove aks connection create postgres cmd aks connection create postgres removed parameter key_vault_id please add back parameter key_vault_id for cmd aks connection create postgres
1007 - ParaRemove aks connection create postgres-flexible cmd aks connection create postgres-flexible removed parameter key_vault_id please add back parameter key_vault_id for cmd aks connection create postgres-flexible
1007 - ParaRemove aks connection create sql cmd aks connection create sql removed parameter key_vault_id please add back parameter key_vault_id for cmd aks connection create sql
⚠️ 1006 - ParaAdd aks connection create mysql-flexible cmd aks connection create mysql-flexible added parameter app_config_id
⚠️ 1006 - ParaAdd aks connection create mysql-flexible cmd aks connection create mysql-flexible added parameter opt_out_list
⚠️ 1006 - ParaAdd aks connection create postgres cmd aks connection create postgres added parameter app_config_id
⚠️ 1006 - ParaAdd aks connection create postgres cmd aks connection create postgres added parameter opt_out_list
⚠️ 1006 - ParaAdd aks connection create postgres-flexible cmd aks connection create postgres-flexible added parameter app_config_id
⚠️ 1006 - ParaAdd aks connection create postgres-flexible cmd aks connection create postgres-flexible added parameter opt_out_list
⚠️ 1006 - ParaAdd aks connection create sql cmd aks connection create sql added parameter app_config_id
⚠️ 1006 - ParaAdd aks connection create sql cmd aks connection create sql added parameter opt_out_list
⚠️ 1006 - ParaAdd containerapp connection create mysql-flexible cmd containerapp connection create mysql-flexible added parameter app_config_id
⚠️ 1006 - ParaAdd containerapp connection create mysql-flexible cmd containerapp connection create mysql-flexible added parameter opt_out_list
⚠️ 1006 - ParaAdd containerapp connection create postgres cmd containerapp connection create postgres added parameter app_config_id
⚠️ 1006 - ParaAdd containerapp connection create postgres cmd containerapp connection create postgres added parameter opt_out_list
⚠️ 1006 - ParaAdd containerapp connection create postgres-flexible cmd containerapp connection create postgres-flexible added parameter app_config_id
⚠️ 1006 - ParaAdd containerapp connection create postgres-flexible cmd containerapp connection create postgres-flexible added parameter opt_out_list
⚠️ 1006 - ParaAdd containerapp connection create sql cmd containerapp connection create sql added parameter app_config_id
⚠️ 1006 - ParaAdd containerapp connection create sql cmd containerapp connection create sql added parameter opt_out_list
⚠️ 1006 - ParaAdd functionapp connection create mysql-flexible cmd functionapp connection create mysql-flexible added parameter app_config_id
⚠️ 1006 - ParaAdd functionapp connection create mysql-flexible cmd functionapp connection create mysql-flexible added parameter opt_out_list
⚠️ 1006 - ParaAdd functionapp connection create postgres cmd functionapp connection create postgres added parameter app_config_id
⚠️ 1006 - ParaAdd functionapp connection create postgres cmd functionapp connection create postgres added parameter opt_out_list
⚠️ 1006 - ParaAdd functionapp connection create postgres-flexible cmd functionapp connection create postgres-flexible added parameter app_config_id
⚠️ 1006 - ParaAdd functionapp connection create postgres-flexible cmd functionapp connection create postgres-flexible added parameter opt_out_list
⚠️ 1006 - ParaAdd functionapp connection create sql cmd functionapp connection create sql added parameter app_config_id
⚠️ 1006 - ParaAdd functionapp connection create sql cmd functionapp connection create sql added parameter opt_out_list
⚠️ 1006 - ParaAdd webapp connection create mysql-flexible cmd webapp connection create mysql-flexible added parameter app_config_id
⚠️ 1006 - ParaAdd webapp connection create mysql-flexible cmd webapp connection create mysql-flexible added parameter opt_out_list
⚠️ 1006 - ParaAdd webapp connection create postgres cmd webapp connection create postgres added parameter app_config_id
⚠️ 1006 - ParaAdd webapp connection create postgres cmd webapp connection create postgres added parameter opt_out_list
⚠️ 1006 - ParaAdd webapp connection create postgres-flexible cmd webapp connection create postgres-flexible added parameter app_config_id
⚠️ 1006 - ParaAdd webapp connection create postgres-flexible cmd webapp connection create postgres-flexible added parameter opt_out_list
⚠️ 1006 - ParaAdd webapp connection create sql cmd webapp connection create sql added parameter app_config_id
⚠️ 1006 - ParaAdd webapp connection create sql cmd webapp connection create sql added parameter opt_out_list

@yonzhan
Copy link
Collaborator

yonzhan commented May 6, 2024

Service Connector

Copy link

@MoazzemHossain-bot MoazzemHossain-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks and gladly approved.

Copy link

github-actions bot commented May 6, 2024

For more info about extension versioning, please refer to Extension version schema

Copy link

@MoazzemHossain-bot MoazzemHossain-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting you to change as well.

Copy link

@MoazzemHossain-bot MoazzemHossain-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you can change as required that would be greatly appreciated.

Copy link

@MoazzemHossain-bot MoazzemHossain-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you can change as required that would be greatly appreciated.

@yonzhan
Copy link
Collaborator

yonzhan commented May 6, 2024

Please fix CI issues.

@kairu-ms kairu-ms merged commit e676998 into Azure:main May 7, 2024
15 checks passed
@azclibot
Copy link
Collaborator

azclibot commented May 7, 2024

[Release] Update index.json for extension [ serviceconnector-passwordless ] : https://dev.azure.com/azclitools/release/_build/results?buildId=155546&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failure of az containerapp connection create postgres with 'Namespace' object has no attribute 'opt_out_list'
8 participants