Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{AKS} Set disable local accounts to true when creating an automatic cluster #7580

Merged
merged 38 commits into from
May 7, 2024

Conversation

xmzhao0822
Copy link
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az aks create -g xmrg -n xmmc --sku automatic

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented May 6, 2024

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

Copy link

Hi @xmzhao0822,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented May 6, 2024

AKS

Copy link

github-actions bot commented May 6, 2024

For more info about extension versioning, please refer to Extension version schema

@FumingZhang
Copy link
Member

The change looks good, waiting for feature owner to provide a proof of passed live test

@xmzhao0822
Copy link
Contributor Author

xmzhao0822 commented May 7, 2024

The change looks good, waiting for feature owner to provide a proof of passed live test

Do I need to push the live passed recordings change at here?

@FumingZhang
Copy link
Member

The change looks good, waiting for feature owner to provide a proof of passed live test

Do I need to push the live passed recordings change at here?

the recording file is not that important, it would be great if the live test pipeline could pass, I queued another one in eastus

@xmzhao0822
Copy link
Contributor Author

The change looks good, waiting for feature owner to provide a proof of passed live test

Do I need to push the live passed recordings change at here?

the recording file is not that important, it would be great if the live test pipeline could pass, I queued another one in eastus

The live test pipeline in the EastUS has passed :)

@zhoxing-ms zhoxing-ms merged commit 32e7815 into Azure:main May 7, 2024
15 checks passed
@azclibot
Copy link
Collaborator

azclibot commented May 7, 2024

[Release] Update index.json for extension [ aks-preview ] : https://dev.azure.com/azclitools/release/_build/results?buildId=155564&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AKS Auto-Assign Auto assign by bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants