Adding support for CMK encryption settings #7585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| dataprotection backup-vault create | cmd dataprotection backup-vault create added parameter cmk_encryption_key_uri |
||
| dataprotection backup-vault create | cmd dataprotection backup-vault create added parameter cmk_encryption_state |
||
| dataprotection backup-vault create | cmd dataprotection backup-vault create added parameter cmk_identity_type |
||
| dataprotection backup-vault create | cmd dataprotection backup-vault create added parameter cmk_infrastructure_encryption |
||
| dataprotection backup-vault create | cmd dataprotection backup-vault create added parameter cmk_user_assigned_identity_id |
||
| dataprotection backup-vault create | cmd dataprotection backup-vault create added parameter user_assigned_identities |
||
| dataprotection backup-vault update | cmd dataprotection backup-vault update added parameter cmk_encryption_key_uri |
||
| dataprotection backup-vault update | cmd dataprotection backup-vault update added parameter cmk_encryption_state |
||
| dataprotection backup-vault update | cmd dataprotection backup-vault update added parameter cmk_identity_type |
||
| dataprotection backup-vault update | cmd dataprotection backup-vault update added parameter cmk_user_assigned_identity_id |
||
| dataprotection backup-vault update | cmd dataprotection backup-vault update added parameter user_assigned_identities |
|
Hi @Karmah24, |
azure-client-tools-bot-prd
bot
added this to the May 2024 (2024-05-21)❗ Breaking change release ❗ milestone
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
microsoft-github-policy-service
bot
added
the
customer-reported
|
For more info about extension versioning, please refer to Extension version schema |
|
Dear concern,
Thank you very much for your kind cooperation. I am sorry to say, I don't have experience in this regard as because unable to give proper support, would like to request your kind favor to resolve this issue, if possible!
With Regards,
Moazzem Hossain
…________________________________
From: github-actions[bot] ***@***.***>
Sent: 07 May 2024 3:51 PM
To: Azure/azure-cli-extensions ***@***.***>
Cc: Subscribed ***@***.***>
Subject: Re: [Azure/azure-cli-extensions] Adding support for CMK encryption settings (PR #7585)
|
zubairabid
suggested changes
May 8, 2024
src/dataprotection/azext_dataprotection/aaz/latest/dataprotection/backup_vault/_create.py
Outdated
Show resolved
Hide resolved
src/dataprotection/azext_dataprotection/tests/latest/test_dataprotection_backup_vault.py
Show resolved
Hide resolved
Moazzem-Hossain-pixel
approved these changes
May 8, 2024
added 2 commits
May 9, 2024 11:46
…identity-type" This reverts commit a22734f.
evelyn-ys
reviewed
May 10, 2024
evelyn-ys
approved these changes
May 10, 2024
|
[Release] Update index.json for extension [ dataprotection ] : https://dev.azure.com/azclitools/release/_build/results?buildId=157028&view=results |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.