{AKS} Improve Windows OutboundNat test case by removing Windows OSSKU limitation #7586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️Azure CLI Extensions Breaking Change Test
|
azure-client-tools-bot-prd
bot
added this to the May 2024 (2024-05-21)❗ Breaking change release ❗ milestone
|
Hi @ShiqianTao, |
|
AKS |
microsoft-github-policy-service
bot
requested review from
zhoxing-ms,
yanzhudd and
yonzhan
|
Please investigate why the tests failed. |
|
Please fix CI issues |
ShiqianTao
force-pushed
the
shtao/test-remove-limit
branch
from
3262894
to
601449d
Compare
ShiqianTao
force-pushed
the
shtao/test-remove-limit
branch
from
601449d
to
8a790c3
Compare
FumingZhang
reviewed
May 10, 2024
| @@ -2798,16 +2798,14 @@ def test_aks_nodepool_add_with_disable_windows_outbound_nat( | |||
| ], | |||
| ) | |||
|
|
|||
| # add Windows2019 nodepool | |||
| # Windows2022 does not support this feature yet | |||
| # add Windows nodepool with disable windows outbound NAT | |||
There was a problem hiding this comment.
Author queued live test, test passed!
- test_aks_nodepool_add_with_disable_windows_outbound_nat
|
Hi @zhoxing-ms and @yanzhudd Could you please help to review/merge this PR? Thank you. |
yanzhudd
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
{AKS} Improve Windows OutboundNat test case by removing Windows OSSKU limitation
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.