[AKS] Adding if_match and if_none_match headers for AKS RP #7587

InduSridhar · 2024-05-07T19:02:37Z

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
My extension version conforms to the Extension version schema

For new extensions:

My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

azure-client-tools-bot-prd · 2024-05-07T19:02:40Z

❌Azure CLI Extensions Breaking Change Test

❌aks-preview

rule cmd_name rule_message suggest_message

❌ 1010 - ParaPropUpdate aks nodepool add cmd aks nodepool add update parameter spot_max_price: updated property default from nan to nan please change property default from nan to nan for parameter spot_max_price of cmd aks nodepool add

⚠️ 1006 - ParaAdd aks create cmd aks create added parameter if_match

⚠️ 1006 - ParaAdd aks create cmd aks create added parameter if_none_match

⚠️ 1006 - ParaAdd aks nodepool add cmd aks nodepool add added parameter if_match

⚠️ 1006 - ParaAdd aks nodepool add cmd aks nodepool add added parameter if_none_match

⚠️ 1006 - ParaAdd aks nodepool delete cmd aks nodepool delete added parameter if_match

⚠️ 1006 - ParaAdd aks nodepool update cmd aks nodepool update added parameter if_match

⚠️ 1006 - ParaAdd aks nodepool update cmd aks nodepool update added parameter if_none_match

⚠️ 1006 - ParaAdd aks nodepool upgrade cmd aks nodepool upgrade added parameter if_match

⚠️ 1006 - ParaAdd aks nodepool upgrade cmd aks nodepool upgrade added parameter if_none_match

⚠️ 1006 - ParaAdd aks update cmd aks update added parameter if_match

⚠️ 1006 - ParaAdd aks update cmd aks update added parameter if_none_match

⚠️ 1006 - ParaAdd aks upgrade cmd aks upgrade added parameter if_match

⚠️ 1006 - ParaAdd aks upgrade cmd aks upgrade added parameter if_none_match

azure-client-tools-bot-prd · 2024-05-07T19:02:43Z

Hi @InduSridhar,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

yonzhan · 2024-05-07T19:02:52Z

Thank you for your contribution! We will review the pull request and get back to you soon.

github-actions · 2024-05-07T19:06:16Z

⚠️ Release Suggestions

Module: aks-preview

Update VERSION to 4.0.0b5 in src/aks-preview/setup.py

Notes

Stable/preview tag is inherited from last release. If needed, please add stable/preview label to modify it.
Major/minor/patch/pre increment of version number is calculated by pull request code changes automatically. If needed, please add major/minor/patch/pre label to adjust it.
For more info about extension versioning, please refer to Extension version schema

MoazzemHossain-bot

Thanks for efforts.

MoazzemHossain-bot

Thanks

MoazzemHossain-bot

Pls do as well.

MoazzemHossain-bot

Thanks for your contributions.

FumingZhang

lgtm

src/aks-preview/azext_aks_preview/_params.py

src/aks-preview/azext_aks_preview/tests/latest/test_aks_commands.py

MoazzemHossain-bot

Thanks

MoazzemHossain-bot

Thanks

MoazzemHossain-bot

Pls do as well

MoazzemHossain-bot

Thanks

MoazzemHossain-bot

Thanks

src/aks-preview/azext_aks_preview/agentpool_decorator.py

matthchr

This looks good to me for the most part, I left a few comments. Main person you should get to approve is Fuming.

src/aks-preview/HISTORY.rst

src/aks-preview/azext_aks_preview/_help.py

src/aks-preview/azext_aks_preview/_params.py

…e commands

MoazzemHossain-bot

Thanks

MoazzemHossain-bot

Thank you.

InduSridhar · 2024-05-22T14:51:54Z

Successful test https://dev.azure.com/msazure/CloudNativeCompute/_build/results?buildId=94145423&view=results

src/aks-preview/HISTORY.rst

Adding if_match and if_none_match headers for update

7acc551

InduSridhar requested review from andyliuliming and FumingZhang as code owners May 7, 2024 19:02

azure-client-tools-bot-prd bot added this to the May 2024 (2024-05-21)❗ Breaking change release ❗ milestone May 7, 2024

MoazzemHossain-bot approved these changes May 7, 2024

View reviewed changes

MoazzemHossain-bot suggested changes May 7, 2024

View reviewed changes

Adding parameters to the custom functions

0ab1353

InduSridhar marked this pull request as draft May 7, 2024 21:09

InduSridhar changed the title ~~Adding if_match and if_none_match headers for update~~ [AKS] Adding if_match and if_none_match headers for update May 7, 2024

Test and more command updates

012f4c3

MoazzemHossain-bot approved these changes May 7, 2024

View reviewed changes

yonzhan requested review from zhoxing-ms and yanzhudd May 7, 2024 22:57

yonzhan assigned zhoxing-ms May 7, 2024

FumingZhang reviewed May 8, 2024

View reviewed changes

src/aks-preview/azext_aks_preview/_params.py Outdated Show resolved Hide resolved

src/aks-preview/azext_aks_preview/tests/latest/test_aks_commands.py Show resolved Hide resolved

Cleanup if-none-match for nodepool delete

9f3370d

github-actions bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label May 13, 2024

MoazzemHossain-bot approved these changes May 13, 2024

View reviewed changes

Fix test

3504d74

MoazzemHossain-bot approved these changes May 13, 2024

View reviewed changes

indusridhar added 4 commits May 13, 2024 16:09

Clean up code

4d17b68

Updating test

ed0a9f9

Adding etag headers for aks create command

1211611

Add arg for test

8407e67

MoazzemHossain-bot suggested changes May 14, 2024

View reviewed changes

MoazzemHossain-bot approved these changes May 15, 2024

View reviewed changes

Lint fix

76f0c5c

InduSridhar marked this pull request as ready for review May 16, 2024 04:48

InduSridhar requested a review from FumingZhang May 16, 2024 15:56

FumingZhang reviewed May 17, 2024

View reviewed changes

src/aks-preview/azext_aks_preview/agentpool_decorator.py Outdated Show resolved Hide resolved

Lint fixes

a3cf280

InduSridhar requested a review from FumingZhang May 17, 2024 21:46

Resolve merge conflicts

ef2c58d

github-actions bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label May 20, 2024

matthchr approved these changes May 21, 2024

View reviewed changes

src/aks-preview/HISTORY.rst Outdated Show resolved Hide resolved

src/aks-preview/azext_aks_preview/_help.py Outdated Show resolved Hide resolved

src/aks-preview/azext_aks_preview/_params.py Show resolved Hide resolved

AllyW removed the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label May 21, 2024

AllyW mentioned this pull request May 21, 2024

{CI} Fix script re for version extract #7649

Merged

4 tasks

More details in description and also adding the parameters for upgrad…

5165f4a

…e commands

github-actions bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label May 21, 2024

Minor desc update

7c698c2

MoazzemHossain-bot approved these changes May 21, 2024

View reviewed changes

typo fix

10cc8af

MoazzemHossain-bot approved these changes May 21, 2024

View reviewed changes

indusridhar added 2 commits May 21, 2024 15:45

Fix test for delete

2b28656

Fixing test failure due to arg name

bd876ea

AllyW mentioned this pull request May 22, 2024

default nan comparison failure Azure/azure-cli-dev-tools#452

Open

AllyW removed the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label May 22, 2024

indusridhar added 2 commits May 22, 2024 10:31

Lint fix

6dc71f5

More lint fixes

92a3ec6

FumingZhang reviewed May 28, 2024

View reviewed changes

src/aks-preview/HISTORY.rst Outdated Show resolved Hide resolved

Update src/aks-preview/HISTORY.rst

54b3d9e

yanzhudd approved these changes May 28, 2024

View reviewed changes

yanzhudd merged commit 39b1fa0 into Azure:main May 28, 2024
16 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[AKS] Adding if_match and if_none_match headers for AKS RP #7587

[AKS] Adding if_match and if_none_match headers for AKS RP #7587

InduSridhar commented May 7, 2024

azure-client-tools-bot-prd bot commented May 7, 2024 •

edited

Loading

azure-client-tools-bot-prd bot commented May 7, 2024

yonzhan commented May 7, 2024

github-actions bot commented May 7, 2024 •

edited

Loading

MoazzemHossain-bot left a comment

MoazzemHossain-bot left a comment

MoazzemHossain-bot left a comment

MoazzemHossain-bot left a comment

FumingZhang left a comment

MoazzemHossain-bot left a comment

MoazzemHossain-bot left a comment

MoazzemHossain-bot left a comment

MoazzemHossain-bot left a comment

MoazzemHossain-bot left a comment

matthchr left a comment

MoazzemHossain-bot left a comment

MoazzemHossain-bot left a comment

InduSridhar commented May 22, 2024

[AKS] Adding if_match and if_none_match headers for AKS RP #7587

[AKS] Adding if_match and if_none_match headers for AKS RP #7587

Conversation

InduSridhar commented May 7, 2024

Related command

General Guidelines

About Extension Publish

azure-client-tools-bot-prd bot commented May 7, 2024 • edited Loading

azure-client-tools-bot-prd bot commented May 7, 2024

yonzhan commented May 7, 2024

github-actions bot commented May 7, 2024 • edited Loading

⚠️ Release Suggestions

Module: aks-preview

Notes

MoazzemHossain-bot left a comment

Choose a reason for hiding this comment

MoazzemHossain-bot left a comment

Choose a reason for hiding this comment

MoazzemHossain-bot left a comment

Choose a reason for hiding this comment

MoazzemHossain-bot left a comment

Choose a reason for hiding this comment

FumingZhang left a comment

Choose a reason for hiding this comment

MoazzemHossain-bot left a comment

Choose a reason for hiding this comment

MoazzemHossain-bot left a comment

Choose a reason for hiding this comment

MoazzemHossain-bot left a comment

Choose a reason for hiding this comment

MoazzemHossain-bot left a comment

Choose a reason for hiding this comment

MoazzemHossain-bot left a comment

Choose a reason for hiding this comment

matthchr left a comment

Choose a reason for hiding this comment

MoazzemHossain-bot left a comment

Choose a reason for hiding this comment

MoazzemHossain-bot left a comment

Choose a reason for hiding this comment

InduSridhar commented May 22, 2024

azure-client-tools-bot-prd bot commented May 7, 2024 •

edited

Loading

github-actions bot commented May 7, 2024 •

edited

Loading