Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Container app] az containerapp compose create: Fix issue #7542 where the environment's location is not resolved from --location #7598

Merged
merged 1 commit into from
May 9, 2024

Conversation

Greedygre
Copy link
Contributor

@Greedygre Greedygre commented May 9, 2024


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

Fix issue: #7542

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented May 9, 2024

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

Copy link

Hi @Greedygre,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Auto-Assign Auto assign by bot label May 9, 2024
@Greedygre Greedygre changed the title [Container app] az containerapp compose create: Fix an [issue](https://github.com/Azure/azure-cli-extensions/issues/7542) where the environment's location is not resolved from --location [Container app] az containerapp compose create: Fix issue #7542 where the environment's location is not resolved from --location May 9, 2024
Copy link

github-actions bot commented May 9, 2024

⚠️ Release Suggestions

Module: containerapp

  • Update VERSION to 1.0.0b1 in src/containerapp/setup.py

Notes

  • Stable/preview tag is inherited from last release. If needed, please add stable/preview label to modify it.
  • Major/minor/patch/pre increment of version number is calculated by pull request code changes automatically. If needed, please add major/minor/patch/pre label to adjust it.
  • For more info about extension versioning, please refer to Extension version schema

@yonzhan
Copy link
Collaborator

yonzhan commented May 9, 2024

Container app

@yonzhan
Copy link
Collaborator

yonzhan commented May 9, 2024

Please fix CI issues

@Greedygre
Copy link
Contributor Author

Azure.azure-cli-extensions (azdev style on Modified Extensions

Hi
The Azure.azure-cli-extensions (azdev style on Modified Extensions is not related to this PR, these style issue are existing in the original code.

@zhoxing-ms zhoxing-ms merged commit 486d5b9 into Azure:main May 9, 2024
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Assign Auto assign by bot ContainerApp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants