Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{AKS} Support Mixed SKU VMs agentpool #7600

Merged
merged 8 commits into from
May 20, 2024
Merged

Conversation

HuShaoRu
Copy link
Contributor

@HuShaoRu HuShaoRu commented May 9, 2024


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az aks create --vm-sizes
az aks nodepool add --vm-sizes
az aks nodepool manual-scale add
az aks nodepool manual-scale update
az aks nodepool manual-scale delete

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented May 9, 2024

❌Azure CLI Extensions Breaking Change Test
❌aks-preview
rule cmd_name rule_message suggest_message
1010 - ParaPropUpdate aks nodepool add cmd aks nodepool add update parameter spot_max_price: updated property default from nan to nan please change property default from nan to nan for parameter spot_max_price of cmd aks nodepool add
⚠️ 1006 - ParaAdd aks create cmd aks create added parameter vm_sizes
⚠️ 1006 - ParaAdd aks nodepool add cmd aks nodepool add added parameter vm_sizes
⚠️ 1011 - SubgroupAdd aks nodepool manual-scale sub group aks nodepool manual-scale added

Copy link

Hi @HuShaoRu,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented May 9, 2024

AKS

Copy link

github-actions bot commented May 9, 2024

For more info about extension versioning, please refer to Extension version schema

Copy link
Member

@FumingZhang FumingZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Queued live test for updated test case

  • test_vms_agentpool_type

src/aks-preview/azext_aks_preview/custom.py Outdated Show resolved Hide resolved
src/aks-preview/azext_aks_preview/custom.py Outdated Show resolved Hide resolved
src/aks-preview/azext_aks_preview/custom.py Outdated Show resolved Hide resolved
src/aks-preview/azext_aks_preview/_params.py Show resolved Hide resolved
src/aks-preview/azext_aks_preview/custom.py Outdated Show resolved Hide resolved
src/aks-preview/azext_aks_preview/custom.py Show resolved Hide resolved
Copy link

@MoazzemHossain-bot MoazzemHossain-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Copy link

@MoazzemHossain-bot MoazzemHossain-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do the necessary changes

Copy link

@MoazzemHossain-bot MoazzemHossain-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for supporting.

@HuShaoRu HuShaoRu closed this May 14, 2024
@HuShaoRu HuShaoRu reopened this May 14, 2024
@HuShaoRu
Copy link
Contributor Author

We may not pass live test now. Some related features are only supported in some subscriptions (will open to other subscriptions soon). I chose the right subscription locally so I could get the test_.yaml.

@FumingZhang
Copy link
Member

We may not pass live test now. Some related features are only supported in some subscriptions (will open to other subscriptions soon). I chose the right subscription locally so I could get the test_.yaml.

If the test case could not be executed in a bare sub, please exclude test case from the default test matrix (src/aks-preview/azcli_aks_live_test/configs/ext_matrix_default.json). And add it back later when the feature is ready later.

Copy link

@Moazzem-Hossain-pixel Moazzem-Hossain-pixel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Copy link

@Moazzem-Hossain-pixel Moazzem-Hossain-pixel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@github-actions github-actions bot added release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. and removed release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. labels May 15, 2024
Copy link
Member

@FumingZhang FumingZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AllyW AllyW added release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. and removed release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. labels May 17, 2024
@zhoxing-ms zhoxing-ms merged commit 241505c into Azure:main May 20, 2024
18 of 19 checks passed
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ aks-preview ] : https://dev.azure.com/azclitools/release/_build/results?buildId=159929&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AKS Auto-Assign Auto assign by bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants