Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Containerapp] Support java agent #7615

Merged
merged 19 commits into from
May 16, 2024
Merged

Conversation

fangjian0423
Copy link
Contributor

@fangjian0423 fangjian0423 commented May 14, 2024

Design doc: https://github.com/serverless-paas-balam/k4apps/discussions/4502

Enable Java agent:

az containerapp create ... --runtime java --enable-java-agent
az containerapp update ... --runtime java --enable-java-agent

Java logger operation:
az containerapp java logger set --logger-name "root" --logger-level "debug"
az containerapp java logger show --logger-name "root"
az containerapp java logger show --all
az containerapp java logger delete --logger-name "root"
az containerapp java logger delete --all


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented May 14, 2024

⚠️Azure CLI Extensions Breaking Change Test
⚠️containerapp
rule cmd_name rule_message suggest_message
⚠️ 1006 - ParaAdd containerapp create cmd containerapp create added parameter enable_java_agent
⚠️ 1011 - SubgroupAdd containerapp java sub group containerapp java added
⚠️ 1006 - ParaAdd containerapp update cmd containerapp update added parameter enable_java_agent

Copy link

Hi @fangjian0423,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

Copy link

Hi @fangjian0423,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented May 14, 2024

Containerapp

Copy link

github-actions bot commented May 14, 2024

⚠️ Release Suggestions

Module: containerapp

  • Update VERSION to 1.0.0b1 in src/containerapp/setup.py

Notes

  • Stable/preview tag is inherited from last release. If needed, please add stable/preview label to modify it.
  • Major/minor/patch/pre increment of version number is calculated by pull request code changes automatically. If needed, please add major/minor/patch/pre label to adjust it.
  • For more info about extension versioning, please refer to Extension version schema

@fangjian0423
Copy link
Contributor Author

Do we support uppercase log level or mixed? Can we do az containerapp java logger set --logger-name root --log-level Warn?

mixed, cli will convert to lowercase.

Copy link

@Moazzem-Hossain-pixel Moazzem-Hossain-pixel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@yanzhudd yanzhudd merged commit 82c56fb into Azure:main May 16, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Assign Auto assign by bot ContainerApp
Projects
None yet
Development

Successfully merging this pull request may close these issues.