Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[monitor-control-service] Update api-version with issue fix #7616

Merged
merged 9 commits into from
Jun 13, 2024

Conversation

AllyW
Copy link
Member

@AllyW AllyW commented May 14, 2024


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

closed #7496
closed #7157
closed Azure/azure-cli#28827
closed #7399

Copy link

azure-client-tools-bot-prd bot commented May 14, 2024

⚠️Azure CLI Extensions Breaking Change Test
⚠️monitor-control-service
rule cmd_name rule_message suggest_message
⚠️ 1009 - ParaPropRemove monitor data-collection endpoint create cmd monitor data-collection endpoint create update parameter public_network_access: removed property choices=['Disabled', 'Enabled', 'SecuredByPerimeter']
⚠️ 1009 - ParaPropRemove monitor data-collection endpoint update cmd monitor data-collection endpoint update update parameter public_network_access: removed property choices=['Disabled', 'Enabled', 'SecuredByPerimeter']
⚠️ 1006 - ParaAdd monitor data-collection rule create cmd monitor data-collection rule create added parameter agent_settings
⚠️ 1006 - ParaAdd monitor data-collection rule create cmd monitor data-collection rule create added parameter references
⚠️ 1006 - ParaAdd monitor data-collection rule delete cmd monitor data-collection rule delete added parameter delete_associations
⚠️ 1006 - ParaAdd monitor data-collection rule update cmd monitor data-collection rule update added parameter agent_settings
⚠️ 1006 - ParaAdd monitor data-collection rule update cmd monitor data-collection rule update added parameter references

Copy link

Hi @AllyW,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

Copy link

Hi @AllyW,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

@yonzhan
Copy link
Collaborator

yonzhan commented May 14, 2024

monitor-control-service

Copy link

github-actions bot commented May 14, 2024

For more info about extension versioning, please refer to Extension version schema

@AllyW AllyW merged commit 08dbb4c into Azure:main Jun 13, 2024
16 checks passed
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ monitor-control-service ] : https://dev.azure.com/azclitools/release/_build/results?buildId=164940&view=results

liorstauber pushed a commit to liorstauber/azure-cli-extensions that referenced this pull request Jul 14, 2024
* add api-version update and enum support extension
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment