[ContainerApp] Bug fix update container name #7623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
requested review from
pagariyaalok,
Juliehzl,
jijohn14 and
Greedygre
|
|
Hi @snehapar9 |
Thank you for catching that @Greedygre! Removed it |
|
Please modify |
JennyLawrance
approved these changes
May 16, 2024
Greedygre
approved these changes
May 16, 2024
|
please resolve the code conflict |
|
please add test for this change to verify if it can meet your expectations |
Thanks, added test for this scenario and resolved conflicts. |
Greedygre
reviewed
May 16, 2024
Comment on lines
495
to
498
| app = test_cls.cmd(f'containerapp show -g {resource_group} -n {name}').get_output_in_json() | ||
|
|
||
| # Verify that the Container App has the correct environment variables | ||
| test_cls.assertEqual(app["properties"]["template"]["containers"][0]["env"], [{"name": "testkey1", "value": "value1"}, {"name": "testkey2", "value": "value2"}]) |
There was a problem hiding this comment.
You can use checks=[] to check the properties
There was a problem hiding this comment.
self.cmd('containerapp show -g {} -n {}'.format(resource_group, ca_name), checks=[
JMESPathCheck('length(properties.template.containers[0].env[?name==`testkey1`])', "value1")
])
Greedygre
reviewed
May 16, 2024
Comment on lines
502
to
505
| app = test_cls.cmd(f'containerapp show -g {resource_group} -n {name}').get_output_in_json() | ||
|
|
||
| # Verify that the Container App has the correct environment variables | ||
| test_cls.assertEqual(app["properties"]["template"]["containers"][0]["env"], [{"name": "testkey1", "value": "value1"}, {"name": "testkey2", "value": "value2"}]) |
Greedygre
approved these changes
May 16, 2024
yanzhudd
approved these changes
May 16, 2024
Greedygre
reviewed
May 16, 2024
Comment on lines
+493
to
+503
| # Create and verify Container App using cloud build | ||
| test_cls.cmd(f'containerapp create -g {resource_group} -n {name} --environment {env_name} --source \"{source_path}\" --env-vars "testkey1=value1" "testkey2=value2"') | ||
| test_cls.cmd(f'containerapp show -g {resource_group} -n {name}', checks=[ | ||
| JMESPathCheck('properties.template.containers[0].env', [{'name': 'testkey1', 'value': 'value1'}, {'name': 'testkey2', 'value': 'value2'}]) | ||
| ]) | ||
|
|
||
| # Update and verify Container App using cloud build | ||
| test_cls.cmd(f'containerapp update -g {resource_group} -n {name} --source \"{source_path}\"') | ||
| test_cls.cmd(f'containerapp show -g {resource_group} -n {name}', checks=[ | ||
| JMESPathCheck('properties.template.containers[0].env', [{'name': 'testkey1', 'value': 'value1'}, {'name': 'testkey2', 'value': 'value2'}]) | ||
| ]) |
There was a problem hiding this comment.
Seems you didn't check the container name? I think the container name is the what you want to check, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
This PR ensures the container name is updated after running
updatein source to cloud flow.General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.