Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated api version of providerhub cli to 2024-04-01-preview #7691

Merged
merged 18 commits into from
Jun 27, 2024

Conversation

gaurimadhok
Copy link
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az providerhub

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Jun 7, 2024

❌Azure CLI Extensions Breaking Change Test
❌providerhub
rule cmd_name rule_message suggest_message
1007 - ParaRemove providerhub provider-registration create cmd providerhub provider-registration create removed parameter lighthouse_authorizations please add back parameter lighthouse_authorizations for cmd providerhub provider-registration create
1007 - ParaRemove providerhub provider-registration create cmd providerhub provider-registration create removed parameter managed_by_tenant_id please add back parameter managed_by_tenant_id for cmd providerhub provider-registration create
1007 - ParaRemove providerhub provider-registration create cmd providerhub provider-registration create removed parameter providerhub_metadata_authentication please add back parameter providerhub_metadata_authentication for cmd providerhub provider-registration create
1007 - ParaRemove providerhub provider-registration create cmd providerhub provider-registration create removed parameter providerhub_metadata_authorizations please add back parameter providerhub_metadata_authorizations for cmd providerhub provider-registration create
1007 - ParaRemove providerhub resource-type-registration create cmd providerhub resource-type-registration create removed parameter enable_third_party_s2s please add back parameter enable_third_party_s2s for cmd providerhub resource-type-registration create
1007 - ParaRemove providerhub resource-type-registration create cmd providerhub resource-type-registration create removed parameter resource_patch_begin please add back parameter resource_patch_begin for cmd providerhub resource-type-registration create
1007 - ParaRemove providerhub sku create cmd providerhub sku create removed parameter nested_resource_type_first please add back parameter nested_resource_type_first for cmd providerhub sku create
1007 - ParaRemove providerhub sku create cmd providerhub sku create removed parameter nested_resource_type_second please add back parameter nested_resource_type_second for cmd providerhub sku create
1007 - ParaRemove providerhub sku create cmd providerhub sku create removed parameter nested_resource_type_third please add back parameter nested_resource_type_third for cmd providerhub sku create
1007 - ParaRemove providerhub sku delete cmd providerhub sku delete removed parameter nested_resource_type_first please add back parameter nested_resource_type_first for cmd providerhub sku delete
1007 - ParaRemove providerhub sku delete cmd providerhub sku delete removed parameter nested_resource_type_second please add back parameter nested_resource_type_second for cmd providerhub sku delete
1007 - ParaRemove providerhub sku delete cmd providerhub sku delete removed parameter nested_resource_type_third please add back parameter nested_resource_type_third for cmd providerhub sku delete
1007 - ParaRemove providerhub sku list cmd providerhub sku list removed parameter nested_resource_type_first please add back parameter nested_resource_type_first for cmd providerhub sku list
1007 - ParaRemove providerhub sku list cmd providerhub sku list removed parameter nested_resource_type_second please add back parameter nested_resource_type_second for cmd providerhub sku list
1007 - ParaRemove providerhub sku list cmd providerhub sku list removed parameter nested_resource_type_third please add back parameter nested_resource_type_third for cmd providerhub sku list
1002 - CmdRemove providerhub sku show-nested-resource-type-first cmd providerhub sku show-nested-resource-type-first removed please confirm cmd providerhub sku show-nested-resource-type-first removed
1002 - CmdRemove providerhub sku show-nested-resource-type-second cmd providerhub sku show-nested-resource-type-second removed please confirm cmd providerhub sku show-nested-resource-type-second removed
1002 - CmdRemove providerhub sku show-nested-resource-type-third cmd providerhub sku show-nested-resource-type-third removed please confirm cmd providerhub sku show-nested-resource-type-third removed

Copy link

Hi @gaurimadhok,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Jun 7, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link

github-actions bot commented Jun 7, 2024

⚠️ Release Suggestions

Module: providerhub

  • ⚠️ Please log updates into to src/providerhub/HISTORY.rst

Notes

  • Stable/preview tag is inherited from last release. If needed, please add stable/preview label to modify it.
  • Major/minor/patch/pre increment of version number is calculated by pull request code changes automatically. If needed, please add major/minor/patch/pre label to adjust it.
  • For more info about extension versioning, please refer to Extension version schema

Copy link

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

@github-actions github-actions bot added the release-version-block Updates do not qualify release version rules label Jun 20, 2024
@github-actions github-actions bot removed the release-version-block Updates do not qualify release version rules label Jun 20, 2024
@gaurimadhok
Copy link
Contributor Author

❌Azure CLI Extensions Breaking Change Test

❌providerhub

rule
cmd_name
rule_message
suggest_message

1010 - ParaPropUpdate
providerhub default-rollout create
cmd providerhub default-rollout create update parameter rest_of_the_world_group_two: updated property options from ['--rest-of-the-world-group-two', '--row2'] to ['--rest-of-the-world-group-two']
please change property options from ['--rest-of-the-world-group-two'] to ['--rest-of-the-world-group-two', '--row2'] for parameter rest_of_the_world_group_two of cmd providerhub default-rollout create

1010 - ParaPropUpdate
providerhub manifest checkin
cmd providerhub manifest checkin update parameter baseline_arm_manifest_location: updated property options from ['--arm-manifest-location', '--baseline-arm-manifest-location', '--location'] to ['--baseline-arm-manifest-location']
please change property options from ['--baseline-arm-manifest-location'] to ['--arm-manifest-location', '--baseline-arm-manifest-location', '--location'] for parameter baseline_arm_manifest_location of cmd providerhub manifest checkin

1007 - ParaRemove
providerhub provider-registration create
cmd providerhub provider-registration create removed parameter lighthouse_authorizations
please add back parameter lighthouse_authorizations for cmd providerhub provider-registration create

1007 - ParaRemove
providerhub provider-registration create
cmd providerhub provider-registration create removed parameter managed_by_tenant_id
please add back parameter managed_by_tenant_id for cmd providerhub provider-registration create

1007 - ParaRemove
providerhub provider-registration create
cmd providerhub provider-registration create removed parameter providerhub_metadata_authentication
please add back parameter providerhub_metadata_authentication for cmd providerhub provider-registration create

1007 - ParaRemove
providerhub provider-registration create
cmd providerhub provider-registration create removed parameter providerhub_metadata_authorizations
please add back parameter providerhub_metadata_authorizations for cmd providerhub provider-registration create

1010 - ParaPropUpdate
providerhub provider-registration create
cmd providerhub provider-registration create update parameter subscription_state_override_actions: updated property options from ['--override-actions', '--subscription-state-override-actions'] to ['--subscription-state-override-actions']
please change property options from ['--subscription-state-override-actions'] to ['--override-actions', '--subscription-state-override-actions'] for parameter subscription_state_override_actions of cmd providerhub provider-registration create

1010 - ParaPropUpdate
providerhub provider-registration create
cmd providerhub provider-registration create update parameter template_deployment_options: updated property options from ['--template-deployment-options', '--tmplt-deploy-opt'] to ['--template-deployment-options']
please change property options from ['--template-deployment-options'] to ['--template-deployment-options', '--tmplt-deploy-opt'] for parameter template_deployment_options of cmd providerhub provider-registration create

1007 - ParaRemove
providerhub resource-type-registration create
cmd providerhub resource-type-registration create removed parameter enable_third_party_s2s
please add back parameter enable_third_party_s2s for cmd providerhub resource-type-registration create

1007 - ParaRemove
providerhub resource-type-registration create
cmd providerhub resource-type-registration create removed parameter resource_patch_begin
please add back parameter resource_patch_begin for cmd providerhub resource-type-registration create

1010 - ParaPropUpdate
providerhub resource-type-registration create
cmd providerhub resource-type-registration create update parameter subscription_state_override_actions: updated property options from ['--override-actions', '--subscription-state-override-actions'] to ['--subscription-state-override-actions']
please change property options from ['--subscription-state-override-actions'] to ['--override-actions', '--subscription-state-override-actions'] for parameter subscription_state_override_actions of cmd providerhub resource-type-registration create

1007 - ParaRemove
providerhub sku create
cmd providerhub sku create removed parameter nested_resource_type_first
please add back parameter nested_resource_type_first for cmd providerhub sku create

1007 - ParaRemove
providerhub sku create
cmd providerhub sku create removed parameter nested_resource_type_second
please add back parameter nested_resource_type_second for cmd providerhub sku create

1007 - ParaRemove
providerhub sku create
cmd providerhub sku create removed parameter nested_resource_type_third
please add back parameter nested_resource_type_third for cmd providerhub sku create

1007 - ParaRemove
providerhub sku delete
cmd providerhub sku delete removed parameter nested_resource_type_first
please add back parameter nested_resource_type_first for cmd providerhub sku delete

1007 - ParaRemove
providerhub sku delete
cmd providerhub sku delete removed parameter nested_resource_type_second
please add back parameter nested_resource_type_second for cmd providerhub sku delete

1007 - ParaRemove
providerhub sku delete
cmd providerhub sku delete removed parameter nested_resource_type_third
please add back parameter nested_resource_type_third for cmd providerhub sku delete

1007 - ParaRemove
providerhub sku list
cmd providerhub sku list removed parameter nested_resource_type_first
please add back parameter nested_resource_type_first for cmd providerhub sku list

1007 - ParaRemove
providerhub sku list
cmd providerhub sku list removed parameter nested_resource_type_second
please add back parameter nested_resource_type_second for cmd providerhub sku list

1007 - ParaRemove
providerhub sku list
cmd providerhub sku list removed parameter nested_resource_type_third
please add back parameter nested_resource_type_third for cmd providerhub sku list

1002 - CmdRemove
providerhub sku show-nested-resource-type-first
cmd providerhub sku show-nested-resource-type-first removed
please confirm cmd providerhub sku show-nested-resource-type-first removed

1002 - CmdRemove
providerhub sku show-nested-resource-type-second
cmd providerhub sku show-nested-resource-type-second removed
please confirm cmd providerhub sku show-nested-resource-type-second removed

1002 - CmdRemove
providerhub sku show-nested-resource-type-third
cmd providerhub sku show-nested-resource-type-third removed
please confirm cmd providerhub sku show-nested-resource-type-third removed

I have reviewed these and updated the ones that needed to be updated.

@yonzhan
Copy link
Collaborator

yonzhan commented Jun 20, 2024

Please fix CI issues

@kairu-ms
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@kairu-ms kairu-ms merged commit c099c40 into Azure:main Jun 27, 2024
18 checks passed
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ providerhub ] : https://dev.azure.com/azclitools/release/_build/results?buildId=168040&view=results

liorstauber pushed a commit to liorstauber/azure-cli-extensions that referenced this pull request Jul 14, 2024
)

* new version of providerhub cli

* change uri to management.azure.com

* update provider reg create test

* update provider reg delete

* update operations type

* delete other test file

* updates from release suggestions

* remove generated folder

* Clean up codes

* fix style and test

* fix linter issues

* .\.azure-pipelines\

* fix linter issues

* fix linter issues

* add in examples

* Example fix

* Update setup.py

---------

Co-authored-by: kai ru <[email protected]>
Co-authored-by: kai ru <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants