Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding space to connected k8s error #7698

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mahomedalid
Copy link

@mahomedalid mahomedalid commented Jun 10, 2024

Summary

This pull request addresses a minor formatting issue in an error message within the project.

image

Description

  • Issue: The error message Problem loading the kubeconfig file.Invalid kube-config. /root/.kube/config file is empty lacks a space after the period in file.
  • Fix: Added a space to correct the formatting. The updated error message now reads: Problem loading the kubeconfig file. Invalid kube-config. /root/.kube/config file is empty

Impact

This change improves the readability and clarity of the error message displayed to users, ensuring better user experience and understanding of the issue.


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az connectedk8s connect

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Jun 10, 2024

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

Copy link

Hi @mahomedalid,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Jun 10, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link

⚠️ Release Suggestions

Module: connectedk8s

  • ⚠️ Please log updates into to src/connectedk8s/HISTORY.rst
  • Update VERSION to 1.7.4 in src/connectedk8s/setup.py

Notes

  • Stable/preview tag is inherited from last release. If needed, please add stable/preview label to modify it.
  • Major/minor/patch/pre increment of version number is calculated by pull request code changes automatically. If needed, please add major/minor/patch/pre label to adjust it.
  • For more info about extension versioning, please refer to Extension version schema

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants