Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EmailService - default Location global for email and domain create and sender username text and example update #7704

Merged
merged 5 commits into from
Jun 17, 2024

Conversation

v-vprasannak
Copy link
Contributor

@v-vprasannak v-vprasannak commented Jun 11, 2024


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Jun 11, 2024

❌Azure CLI Extensions Breaking Change Test
❌communication
rule cmd_name rule_message suggest_message
1008 - ParaPropAdd communication email create cmd communication email create update parameter data_location: added property required=True please remove property required=True for parameter data_location of cmd communication email create
⚠️ 1008 - ParaPropAdd communication email create cmd communication email create update parameter location: added property aaz_default=Global
⚠️ 1008 - ParaPropAdd communication email create cmd communication email create update parameter location: added property default=Global
⚠️ 1008 - ParaPropAdd communication email domain create cmd communication email domain create update parameter location: added property aaz_default=Global
⚠️ 1008 - ParaPropAdd communication email domain create cmd communication email domain create update parameter location: added property default=Global

Copy link

Hi @v-vprasannak,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Jun 11, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

@microsoft-github-policy-service microsoft-github-policy-service bot added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Jun 11, 2024
Copy link

github-actions bot commented Jun 11, 2024

⚠️ Release Suggestions

Module: communication

  • Update VERSION to 2.0.0 in src/communication/setup.py

Notes

  • Stable/preview tag is inherited from last release. If needed, please add stable/preview label to modify it.
  • Major/minor/patch/pre increment of version number is calculated by pull request code changes automatically. If needed, please add major/minor/patch/pre label to adjust it.
  • For more info about extension versioning, please refer to Extension version schema

@kairu-ms kairu-ms merged commit 4b0741b into Azure:main Jun 17, 2024
16 checks passed
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ communication ] : https://dev.azure.com/azclitools/release/_build/results?buildId=165504&view=results

liorstauber pushed a commit to liorstauber/azure-cli-extensions that referenced this pull request Jul 14, 2024
…d sender username text and example update (Azure#7704)

* Email Service - Default location gloabl for create email and domain. Sender username text update

* updated the version and history files

* history update

* Email Service - updating data location as required parameter in documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customer-reported Issues that are reported by GitHub users external to the Azure organization.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants