Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the Az Databricks cli to 2024-05-01 api version. #7707

Merged
merged 6 commits into from
Jul 2, 2024

Conversation

v-vyedavelly
Copy link
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az databricks workspace create/update: Add --access-connector to associate an Access Connector Resource with workspace.
az databricks workspace create/update: Add --default-storage-firewall to set default storage firewall configuration information on workspace.
az databricks workspace create/update: Add --enhanced-security-compliance to enable the Enhanced Security and Compliance on workspace.
az databricks workspace delete: Add --force-deletion to delete all data on Uc enabled workspace.

General Guidelines

  • [Y] Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • [Y] Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • [Y] My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Jun 11, 2024

⚠️Azure CLI Extensions Breaking Change Test
⚠️databricks
rule cmd_name rule_message suggest_message
⚠️ 1006 - ParaAdd databricks access-connector list cmd databricks access-connector list added parameter pagination_limit
⚠️ 1006 - ParaAdd databricks access-connector list cmd databricks access-connector list added parameter pagination_token
⚠️ 1006 - ParaAdd databricks workspace create cmd databricks workspace create added parameter access_connector
⚠️ 1006 - ParaAdd databricks workspace create cmd databricks workspace create added parameter default_catalog
⚠️ 1006 - ParaAdd databricks workspace create cmd databricks workspace create added parameter default_storage_firewall
⚠️ 1006 - ParaAdd databricks workspace create cmd databricks workspace create added parameter enhanced_security_compliance
⚠️ 1006 - ParaAdd databricks workspace delete cmd databricks workspace delete added parameter force_deletion
⚠️ 1006 - ParaAdd databricks workspace list cmd databricks workspace list added parameter pagination_limit
⚠️ 1006 - ParaAdd databricks workspace list cmd databricks workspace list added parameter pagination_token
⚠️ 1006 - ParaAdd databricks workspace private-endpoint-connection list cmd databricks workspace private-endpoint-connection list added parameter pagination_limit
⚠️ 1006 - ParaAdd databricks workspace private-endpoint-connection list cmd databricks workspace private-endpoint-connection list added parameter pagination_token
⚠️ 1006 - ParaAdd databricks workspace private-link-resource list cmd databricks workspace private-link-resource list added parameter pagination_limit
⚠️ 1006 - ParaAdd databricks workspace private-link-resource list cmd databricks workspace private-link-resource list added parameter pagination_token
⚠️ 1006 - ParaAdd databricks workspace update cmd databricks workspace update added parameter access_connector
⚠️ 1006 - ParaAdd databricks workspace update cmd databricks workspace update added parameter default_catalog
⚠️ 1006 - ParaAdd databricks workspace update cmd databricks workspace update added parameter default_storage_firewall
⚠️ 1006 - ParaAdd databricks workspace update cmd databricks workspace update added parameter enhanced_security_compliance
⚠️ 1006 - ParaAdd databricks workspace vnet-peering list cmd databricks workspace vnet-peering list added parameter pagination_limit
⚠️ 1006 - ParaAdd databricks workspace vnet-peering list cmd databricks workspace vnet-peering list added parameter pagination_token

Copy link

Hi @v-vyedavelly,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Jun 11, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link

github-actions bot commented Jun 11, 2024

For more info about extension versioning, please refer to Extension version schema

@github-actions github-actions bot added the release-version-block Updates do not qualify release version rules label Jun 11, 2024
@yonzhan yonzhan requested review from jsntcy and kairu-ms June 11, 2024 22:46
Copy link

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

src/databricks/setup.py Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the release-version-block Updates do not qualify release version rules label Jun 28, 2024
@v-vyedavelly
Copy link
Contributor Author

@yonzhan , All the PR checks were passed, the PR is ready to review and merge.

@kairu-ms
Copy link
Contributor

kairu-ms commented Jul 1, 2024

Please fix the following breaking change. It seems miss an option name. If it's by design, please add it in the release note.

❌Azure CLI Extensions Breaking Change Test

❌databricks

rule
cmd_name
rule_message
suggest_message

1010 - ParaPropUpdate
databricks access-connector update
cmd databricks access-connector update update parameter user_assigned_identities: updated property options from ['--identities', '--user-assigned-identities'] to ['--user-assigned-identities']
please change property options from ['--user-assigned-identities'] to ['--identities', '--user-assigned-identities'] for parameter user_assigned_identities of cmd databricks access-connector update

@kairu-ms kairu-ms merged commit 1be7674 into Azure:main Jul 2, 2024
18 checks passed
@azclibot
Copy link
Collaborator

azclibot commented Jul 2, 2024

[Release] Update index.json for extension [ databricks ] : https://dev.azure.com/azclitools/release/_build/results?buildId=169255&view=results

liorstauber pushed a commit to liorstauber/azure-cli-extensions that referenced this pull request Jul 14, 2024
* Updated the Az Databricks cli to 2024-05-01 api version.

* updated the version

* Updated the Databricks Az Cli cmdlets to 2024-05-01 api version.

* Updated the version. Fixed linter errors.

* Update the History file.

* fixed PR check error

---------

Co-authored-by: root <root@DESKTOP-ADSN5Q0>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants