Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for concurrent connections with tunnels #7719

Merged
merged 3 commits into from
Jun 19, 2024

Conversation

edwardsp
Copy link
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az network bastion tunnel

The current behaviour is to block once there is a connection and this doesn't work if you are forwarding a web server as the browser will start multiple connections.

There has been an issue open for some time on the main azure-cli repository for this issue: Azure/azure-cli#24600

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@yonzhan
Copy link
Collaborator

yonzhan commented Jun 17, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link

azure-client-tools-bot-prd bot commented Jun 17, 2024

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

Copy link

Hi @edwardsp,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

Copy link

github-actions bot commented Jun 17, 2024

For more info about extension versioning, please refer to Extension version schema

The code is consistent with the rest of the file.
Copy link

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

@necusjz necusjz merged commit 568b03a into Azure:main Jun 19, 2024
18 checks passed
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ bastion ] : https://dev.azure.com/azclitools/release/_build/results?buildId=166024&view=results

liorstauber pushed a commit to liorstauber/azure-cli-extensions that referenced this pull request Jul 14, 2024
* Support for concurrent connections with tunnels

* Updated history and incremented patch version

* disabling the broad exception

The code is consistent with the rest of the file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants