Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bastion Developer Sku SSH Integration #7720

Closed
wants to merge 18 commits into from

Conversation

leonardocoba
Copy link


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Jun 17, 2024

⚠️Azure CLI Extensions Breaking Change Test
⚠️ssh
rule cmd_name rule_message suggest_message
⚠️ 1006 - ParaAdd ssh vm cmd ssh vm added parameter bastion
⚠️ 1006 - ParaAdd ssh vm cmd ssh vm added parameter ssh_args
⚠️ 1008 - ParaPropAdd ssh vm cmd ssh vm update parameter ssh_args: added property id_part=resource_group
⚠️ 1009 - ParaPropRemove ssh vm cmd ssh vm update parameter ssh_args: removed property nargs=*
⚠️ 1010 - ParaPropUpdate ssh vm cmd ssh vm update parameter ssh_args: updated property name from ssh_args to resource_group_name
⚠️ 1010 - ParaPropUpdate ssh vm cmd ssh vm update parameter ssh_args: updated property options from [] to ['--resource-group', '-g']

Copy link

Hi @leonardocoba,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Jun 17, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

@microsoft-github-policy-service microsoft-github-policy-service bot added customer-reported Issues that are reported by GitHub users external to the Azure organization. Auto-Assign Auto assign by bot labels Jun 17, 2024
Copy link

⚠️ Release Suggestions

Module: ssh

  • ⚠️ Please log updates into to src/ssh/HISTORY.rst
  • Update VERSION to 2.1.0 in src/ssh/setup.py

Notes

  • Stable/preview tag is inherited from last release. If needed, please add stable/preview label to modify it.
  • Major/minor/patch/pre increment of version number is calculated by pull request code changes automatically. If needed, please add major/minor/patch/pre label to adjust it.
  • For more info about extension versioning, please refer to Extension version schema

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Assign Auto assign by bot customer-reported Issues that are reported by GitHub users external to the Azure organization. Network
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants