Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GA version for command group acat #7723

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

yanshudan
Copy link

@yanshudan yanshudan commented Jun 18, 2024


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

Validation for Breaking Change Starting...

Thanks for your contribution!

Copy link

Hi @yanshudan,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Jun 18, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link

For more info about extension versioning, please refer to Extension version schema

Copy link

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

@kairu-ms kairu-ms self-assigned this Jul 1, 2024
This is an extension to Azure CLI to manage Acat resources.

## How to use ##
Please add commands usage here.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update this readme file. Thanks



@register_command_group(
"acat",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the folder name should be acat not app_compliance_automation

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems you add customization code directly in the generated aaz folder. It's not recommended. I think for you most of your case you only need to implement a custom client which is used to add x-ms-aad-user-token in your header.

pass


class MyBasePolling(LROBasePolling):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the LRO Polling, it could also be implemented in your custom client.

@kairu-ms kairu-ms requested a review from necusjz July 1, 2024 05:11
@kairu-ms kairu-ms assigned necusjz and unassigned jsntcy Jul 1, 2024
@yanshudan yanshudan force-pushed the huiquan-pr branch 5 times, most recently from caad87f to 94ff11c Compare July 5, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants