Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spring]validate path exist before all steps #7725

Merged
merged 11 commits into from
Jul 2, 2024

Conversation

Netyyyy
Copy link
Member

@Netyyyy Netyyyy commented Jun 18, 2024

Verify that artifact-path and source-path exist before all steps in az spring app deploy, az spring app deployment create and az spring job deploy commands.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Jun 18, 2024

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

Copy link

Hi @Netyyyy,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Jun 18, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

Copy link

github-actions bot commented Jun 18, 2024

For more info about extension versioning, please refer to Extension version schema

@Netyyyy Netyyyy changed the title validate path before start create [Spring]validate path before start create Jun 19, 2024
@Netyyyy Netyyyy changed the title [Spring]validate path before start create [Spring]validate path before all steps Jun 19, 2024
@Netyyyy Netyyyy changed the title [Spring]validate path before all steps [Spring]validate path exist before all steps Jun 19, 2024
@Netyyyy Netyyyy marked this pull request as ready for review June 19, 2024 03:12
src/spring/azext_spring/_app_validator.py Outdated Show resolved Hide resolved
src/spring/azext_spring/_app_validator.py Outdated Show resolved Hide resolved
@yonzhan
Copy link
Collaborator

yonzhan commented Jun 19, 2024

Please fix CI issues.

@Netyyyy Netyyyy marked this pull request as draft June 19, 2024 04:44
@Netyyyy Netyyyy marked this pull request as ready for review June 19, 2024 05:46
@Netyyyy
Copy link
Member Author

Netyyyy commented Jun 19, 2024

Please fix CI issues.

Fixed

@Netyyyy
Copy link
Member Author

Netyyyy commented Jun 20, 2024

@zhoxing-ms @yonzhan @yanzhudd , please help take a review, and The failed CI is warning about the original code. Let us keep this PR clean for the new feature and we commit the incremental code passed all CI check.

src/spring/HISTORY.md Outdated Show resolved Hide resolved
@Netyyyy
Copy link
Member Author

Netyyyy commented Jun 26, 2024

@yanzhudd do not know why pipeline failed after updating HISTORY.md and do not have a re-run permission, please help take a look

@yanzhudd
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@Netyyyy
Copy link
Member Author

Netyyyy commented Jul 2, 2024

Hi @yanzhudd please help approve and merge, thanks

@yanzhudd yanzhudd merged commit 35aeac7 into Azure:main Jul 2, 2024
17 of 18 checks passed
@azclibot
Copy link
Collaborator

azclibot commented Jul 2, 2024

[Release] Update index.json for extension [ spring ] : https://dev.azure.com/azclitools/release/_build/results?buildId=169315&view=results

liorstauber pushed a commit to liorstauber/azure-cli-extensions that referenced this pull request Jul 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants